annotated zerver.views.webhooks.jira #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message from Dropbox CLA bot @medullaskyline, it looks like you've already signed the Dropbox CLA. Thanks! |
| @@ -86,7 +90,9 @@ def convert_jira_markup(content, realm): | |||
| def api_jira_webhook(request, user_profile, client, | |||
| payload=REQ(argument_type='body'), | |||
| stream=REQ(default='jira')): | |||
| # type: (HttpRequest, UserProfile, str, Dict[Any, Any], str) -> HttpResponse | |||
There was a problem hiding this comment.
client here is a Client object from zerver.models
There was a problem hiding this comment.
Also, payload is a Dict[str, Any](update this is get_in as well) and stream should be a text_type (since it's unicode)
There was a problem hiding this comment.
Made those fixes, thanks!
medullaskyline
force-pushed
the
mypy-annotation-zerver.views.webhooks.jira
branch
from
11c104d
to
90a8f6e
Compare
|
Merged, thanks @medullaskyline! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.