search: Show category-wise suggestions for has operator. #9453
Conversation
Fixes zulip#9384. Default suggestion e.g `messages with one or more abc` as a suggestion for `has:abc` is not shown in a new suggestion. But if the has operator is already present before any other operator, the default message text will be used. e.g `has:abc sender:abc@zulipchat.com` will have all the suggestions with the prefix `messages with one or more abc, sent by abc@zulipchat.com`.
`has` operator uses predefined categories. This commit displays an invalid operand message if the operand does not fall in to any of these categories and the `has` operator is not at the last. e.g. `has:abc sender:abc@zulipchat.com` will have `invalid abc operand for has operator, sent by abc@zulipchat.com` as a prefix for all its suggestions.
When suggesting operators to chose, category wise suggestions are shown instead of a single default suggestion. e.g suggestions for all the categories of has operator will be show instead of `Messages with one or more` suggestion which did not make sense.
|
Hello @zulip/server-search members, this pull request was labeled with the "area: search" label, so you may want to check it out! |
| }); | ||
|
|
||
| run_test('has_operator_suggestions', () => { | ||
| // Checks that category wise suggestions are displayed instead of a single |
There was a problem hiding this comment.
Although it is checked in the test before this i.e empty_query_suggestions that category wise has operators are shown, changes to that test may push the has suggestions down as they have a low priority. That is why a second test was added.
| @@ -583,6 +618,9 @@ exports.get_suggestions = function (query) { | |||
| suggestions = get_operator_suggestions(last); | |||
| attach_suggestions(result, base, suggestions); | |||
|
|
|||
| suggestions = get_has_filter_suggestions(last, base_operators); | |||
There was a problem hiding this comment.
Seperate functions for is and has filters were created instead of adding the suggestion for has into special_filter_suggestions to take care of the different priorities of the suggestions for both the filters. has suggestions were previously obtained from get_operator_suggestions, therefore placing it directly below that. Also it makes sense for has filter to have a low priority than is as filters like private messages and starred messages maybe used a lot more than has operators.
|
Merged, thanks @shubham-padia! I think there's a clear follow-up here, though, that we should do the same fix for limiting to just valid operators the |
Commit 1:
Default suggestion e.g
messages with one or more abcas a suggestion forhas:abcis not shown in a new suggestion. But if the has operator is already present before any other operator, the default message text will be used. e.ghas:abc sender:abc@zulipchat.comwill have all the suggestions with the prefixmessages with one or more abc, sent by abc@zulipchat.com.Commit 2:
hasoperator uses predefined categories. This commit displays an invalid operand message if the operand does not fall in to any of these categories and thehasoperator is not at the last.e.g.
has:abc sender:abc@zulipchat.comwill haveinvalid abc operand for has operator, sent by abc@zulipchat.comas a prefix for all its suggestions.Commit 3:
Another issue was getting the default suggestion
messages with one or morewhen getting the suggestions for chosing the operator as shown below:This commit takes care of that issue.
Results:
Note: categories exist for the
isoperator, removal of default suggestion needs to be done.