portico: Align ToS checkbox with full name input box. #9478
Conversation
|
Hello @zulip/server-misc members, this pull request was labeled with the "area: portico" label, so you may want to check it out! |
|
@shubham-padia can you explain a bit more what this is doing? Visually, it looks like you added some vertical margin in addition to centering it horizontally? |
Fixes zulip#9328. Makes the width on checkbox input-group same as full name input box width and centers it horizontally.
|
@timabbott I put the left margin as bottom margin in the commit by mistake, I've updated it. |
|
Merged, thanks @shubham-padia! I see how that error happened -- you test it in the browser inspector and then copy it over to the CSS file? I think now that we have hot-module reloading that should be easier to do directly in the CSS file (though it'd be a lot easier if we optimized the webpack compile to be a bit faster). But this may also be a helpful lesson in always re-testing things manually and then re-reading the code as though you didn't just write it as part of the process of submitting code for review (at least, that's what I've been doing for years, and I think it does help minimize mistakes). Anyway, that's mostly a digression on development practices; thanks for cleaning this up! |
Fixes #9328.
Makes the width on checkbox input-group same as full name input box
width and centers it horizontally.