search: Do not show default suggestion for is operator.
#9495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zulip#9492. Default suggestion e.g `abc messages` as a suggestion for `is:abc` is not shown in a new suggestion. But if the is operator is already present before any other operator, the default message text will be used. e.g `is:abc sender:abc@zulipchat.com` will have all the suggestions with the prefix `abc messages, sent by abc@zulipchat.com`.
Fixes zulip#9492. `is` operator uses predefined categories. This commit displays an invalid operand message if the operand does not fall into any of these categories and the `is` operator is not at the last. e.g. `is:abc sender:abc@zulipchat.com` will have `invalid abc operand for has operator, sent by abc@zulipchat.com` as a prefix for all its suggestions.
|
Nice, merged, thanks @shubham-padia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9492.
Commit 1:
Default suggestion e.g
abc messagesas a suggestion foris:abcis not shown in a new suggestion. But if the is operator is already
present before any other operator, the default message text will be
used. e.g
is:abc sender:abc@zulipchat.comwill have all the suggestionswith the prefix
abc messages, sent by abc@zulipchat.com.Commit 2:
isoperator uses predefined categories. This commitdisplays an invalid operand message if the operand does not fall into
any of these categories and the
isoperator is not at the last.e.g.
is:abc sender:abc@zulipchat.comwill haveinvalid abc operand for has operator, sent by abc@zulipchat.comas a prefix for all itssuggestions.