search: Respect spaces in person name in new suggestions only. #9546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6515.
New suggestions for
sender:King ha
will respect spaces and the newsuggestion will be
Sent by King Hamlet <email>
instead ofSent by King, search for ha
. But if first term of sender operand is a valid user email,tokens will be seperated by spaces. e.g
sender:hamlet@zulip.com abc
will show
Sent by King Hamlet <email>, search for abc
.The original issue mentioned
I think that will not be necessary in this case as we are using only emails for filtering. If it's not an exact prefix, e.g
sender:Kin ha
, the prefix check would enable to make the suggestionSent by Kin, search for ha
. But sinceKin
is not a valid email, it's of no use and any query following it would result in empty search. The result without the prefix check would beSent by Kin Ha
. Thus, I think it's better to skip this check and (presumably) save some time. (Let me know if this needs to be changed)