Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import: Clean the management command. #9564

Closed
wants to merge 1 commit into from

Conversation

rheaparekh
Copy link
Collaborator

@rheaparekh rheaparekh commented May 28, 2018

Cleans up:

  • Remove the --import-into-nonempty option (we make that behavior the default). We leave the option present in argparse (and just have it print a warning if passed for now)

  • Improve manage.py import to handle being passed a tarball or give a clear error message if you pass it a tarball.

  • Improve the argument parsing error handling for manage.py import (currently if you forget that argument, it gets confused and tries to use the filename as a subdomain, and gives a confusing error)

I am bit unsure about the third point in issue #9550

I'll also add to my TODO list to update the docs according to this new changes (depreciation of import-into-nonempty) after 1.9 release.

@rheaparekh rheaparekh force-pushed the issue-9550 branch 2 times, most recently from 19d8c14 to eb8f1b0 Compare May 28, 2018 17:36
@timabbott
Copy link
Sponsor Member

Merged as 66e3fc4, after a bit more cleanup and simplification. It does feel a lot nicer now :).

I ended up replacing the tarfile check with just an "is this a directory" one, since that handles other errors nicely as well. Thanks @rheaparekh!

@timabbott timabbott closed this May 28, 2018
@rheaparekh
Copy link
Collaborator Author

@timabbott Yes its definitely much better now!

@rheaparekh rheaparekh deleted the issue-9550 branch May 29, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants