streams: Add create and edit ui for is_announcement_only. #9588
Conversation
shubham-padia
commented
May 30, 2018
shubham-padia
commented
- Default value for is_announcement_only while creating a stream is true
- FYI: taken care of: value of is_annoucement_only populated when opening the privacy modal.
- The second last commit lets only admins set the property while creating a stream. The checkbox disappears for non-admin users. While non-admin users can set other privacy properties, letting a non-admin user create a stream where only admins can post. (If this is not desired, you can skip the commit)
- The last commit just changes, the save button text. I was not sure of this change, that's why the seperate commit. Feel free to skip it. (or change it to something else)
Adds is_announcement_only to create_stream_if_needed and add_subscriptions_backend.
The user can now specify the value while creating a stream. An admin can later change it via `Change stream permissions` modal. Add is_announcement_only to subscription type text.
…eation. Non-admin users cannot see is_announcement_only checkbox while creating a stream. Updating stream privacy properties was already limited to realm admins.
|
Heads up @shubham-padia, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
I merged most of this. I dropped the restriction on who can make one of these to admins; we plan to eventually make it so you can use a user group as the people who can post, so we'd end up reverting that when we add that feature anyway. Thanks @shubham-padia! I opened #9590 for some follow-up issues with the modal. We could probably also benefit from some other styling work, but we should start with that. @Lyla-Fischer FYI -- we should add this feature to the new "stream permissions" user doc you created. |
|
(And we might want to rename that doc from "Stream privacy" to "Stream permissions"). |
