org settings: Enforce unsigned integers on input elements. #9695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rishig what are your thoughts on this? |
shubhamdhama
force-pushed
the
settings-enforce-integer
branch
from
d0a026c
to
35cc861
Compare
There is no simple HTML way to achieve this so used the jQuery hack. It also: Reverts "org settings: Handle floating point durations better for time limits." This reverts commit ccd5581.
shubhamdhama
force-pushed
the
settings-enforce-integer
branch
from
35cc861
to
ec9ce41
Compare
|
Heads up @shubhamdhama, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
I don't think this PR is required now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no simple HTML way to achieve this so used the jQuery hack.
It also:
Reverts "org settings: Handle floating point durations better for
time limits."
This reverts commit ccd5581.
Testing: Manual testing.
[EDIT]: Ahh.. forget to mention the jquery logic is taken from a public jsfiddle https://jsfiddle.net/lesson8/HkEuf/1/