popovers: Enable keyboard navigation on user profile menu. #9734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actions_menu_handle_keyboard now only gets the action menu items and passes them to the newly added popover_items_handle_keyboard. popover_items_handle_keyboard takes the key and menu items as its parameters. The function can be used when handling keyboard input like user profile popover. Similar refactor has been carried out in focus_first_action_popover_item. This refactor is a part of adding the missing support of keyboard navigation to user profile popover.
Gets menu items for the user profile popover. To be used to add keyboard navigation to user_profile_menu.
Adds focus_user_info_popover_item to popovers.js. When menus are opened by hotkeys, first menu item is focused to enable further keyboard navigation.
actions_dropdown_hotkeys are also to be used for user profile menu keyboard navigation, so renaming it to a more generic name.
Fixes zulip#9318. Calls popovers.user_info_popover_handle_keyboard in process_hotkey.js. Makes popovers.message_info_popped public.
|
The code looks nice here, but it doesn't seem to work if I'm Aaron and type "u" over a message sent from Othello. I can arrow to the second item, but not the third. I suspect the selector to find items is broken somehow. |
For other users' profile, keyboard navigation worked only upto 2 items as the third item with '.mention_user' could not be focused. This was due to href missing from the anchor tag. $.focus() requires href to be defined, even if it is '#' to focus the anchor tag.
|
@showell I've updated the PR with the fix. For other users' profile, keyboard navigation worked only upto 2
|
|
Merged, thanks @shubham-padia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9318.
From the original issue:
Keyboard navigation worked in the other menus which were being open by keyboard.