widgets: Increase node tests coverage to 100%. #9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamdhama
commented
Jul 3, 2018
| set_global('document', 'document-stub'); | ||
|
|
||
| let narrow_deactivated_callback; | ||
| $(document).on = (selector, func) => { |
There was a problem hiding this comment.
Not sure about this approach of capturing callback, but I had to do this since $(document).on is global in widetize.js
|
|
shubhamdhama
force-pushed
the
widgets-increase-coverage-100
branch
from
0336865
to
ab7777c
Compare
|
LGTM, ready to merge when build passes |
shubhamdhama
force-pushed
the
widgets-increase-coverage-100
branch
from
ab7777c
to
eb949fb
Compare
|
merged, thanks @shubhamdhama! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, I'll update node tests for
voting_widget.