Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.1 warnings #33

Merged
merged 2 commits into from May 9, 2022
Merged

Fix PHP 8.1 warnings #33

merged 2 commits into from May 9, 2022

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented May 9, 2022 •
edited

Using this library on PHP 8.1 produces the following warning:

Deprecated: Return type of Zumba\Amplitude\Event::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /my/package/vendor/zumba/amplitude-php/src/Event.php on line 324

Also this package should explicitly declare its dependency on the JSON extension.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.027% when pulling 10bf34d on danepowell:php-8.1 into d6d163b on zumba:master.

@danepowell danepowell mentioned this pull request May 9, 2022
Merged
@jonyo jonyo merged commit c0d14d5 into zumba:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonyo jonyo jonyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danepowell @coveralls @jonyo