-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed namespace #19
Conversation
@@ -27,7 +27,7 @@ | |||
"autoload": { | |||
"psr-4": { | |||
"Zumba\\": "src/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrbasso If you specify JsonSerializer
here, you can move the actual class to the root of the src/
directory (per PSR4).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cjsaylor As we talked in person, this was left intentionally to keep the BC with the existent namespace. I marked as deprecated on this version.
@jrbasso Also, needs a rebase. |
What do you think in removing the BC compatibility and just adding a note about it in either the readme or adding a changelog file? If we bump the major version it should be known that there are BC breaking changes. |
@cjsaylor Added a changelog file and rebased. 👍 |
Moving the namespace from
Zumba\Util
to a namespace just for the project (Zumba\JsonSerializer
). I am planning to add more classes, interfaces and traits, which will add things that are not necessarily part of theUtil
namespace.Also, other open source projects that we have also have dedicated namespaces.
PS: The
JsonSerializer
class is the same, just changing the namespace at the top and the exception namespace. It is just how GitHub shows the file change. On the repo it was a file rename.