Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

Added alignment classes to menu bars in order to align menu items #436

Merged
merged 3 commits into from
Feb 9, 2015
Merged

Added alignment classes to menu bars in order to align menu items #436

merged 3 commits into from
Feb 9, 2015

Conversation

tatemz
Copy link
Contributor

@tatemz tatemz commented Feb 3, 2015

These alignment classes will allow menubar menu items to "float" right, center, justified, and spaced.

@tatemz tatemz closed this Feb 3, 2015
@tatemz tatemz deleted the feature/menubar-alignment branch February 3, 2015 20:36
@tatemz tatemz restored the feature/menubar-alignment branch February 3, 2015 20:38
@tatemz tatemz deleted the feature/menubar-alignment branch February 3, 2015 20:38
@tatemz tatemz restored the feature/menubar-alignment branch February 3, 2015 20:39
@tatemz tatemz reopened this Feb 3, 2015
@tatemz
Copy link
Contributor Author

tatemz commented Feb 3, 2015

Darn git-flow...

@gakimball
Copy link
Contributor

Could you use the plain justify-content property instead? Using a grid mixin here means the menu bar would have a dependency on the grid component, and ideally no component is dependent on another (unless it's a sub-component, like button group).

@gakimball gakimball added the sass label Feb 4, 2015
@tatemz
Copy link
Contributor Author

tatemz commented Feb 4, 2015

Understandable. Thanks for the tip. Will update.

@tatemz
Copy link
Contributor Author

tatemz commented Feb 5, 2015

Looks like you guys have a bad gulpfile... ReferenceError: autoprefixer is not defined

Perhaps add var autoprefixer = require('gulp-autoprefixer');

@gakimball
Copy link
Contributor

Ah yeah, it's a typo in the node-sass task. Changing this line of the code will fix it. autoprefixer should be $.autoprefixer.

@gakimball
Copy link
Contributor

Thanks for making the changes. :)

gakimball added a commit that referenced this pull request Feb 9, 2015
Added alignment classes to menu bars in order to align menu items
@gakimball gakimball merged commit 10d4f81 into zurb:master Feb 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants