This repository has been archived by the owner on Sep 10, 2019. It is now read-only.
feat(Iconic): add provider to make 'assetPath' configurable #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And as |
|
Nice, thanks for the work! |
gakimball
added a commit
that referenced
this pull request
Feb 19, 2015
feat(Iconic): add provider to make 'assetPath' configurable
|
@gjungb Can you help out here? http://foundation.zurb.com/forum/posts/26117-how-to-use-of-iconicprovider Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the paid version of the awesome Iconic icons. Thus the default
assetPathin theiconicservice doesn't necessarily fit.So I changed the service to a provider that can be configured via
IconicProvider.setAssetPath(path). If nopathis configured, the default valueassets/img/iconic/is used.