-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery 3 support request #8834
Comments
+1 |
But I think this should be optional. For bigger projects it's not easy to move to jQuery 3. |
At the very least, Foundation should stop using deprecated functions. We tested jQuery 3.0RC on our site but got errors in Foundation because it's still using .load() event handlers that have been deprecated since jQuery 1.8. |
Made a PR (#8923) to remove references to .load() |
As an interim measure it should be possible to simply put jQuery Migrate 3.0 into the site to shim the deprecated functionality. |
+1 |
Ran into this today. What is the status of this? As pointed out this is a function that has been deprecated for a very long time, so shouldn't be used regardless. It was deprecated I think even before JQuery 2 |
+1 |
3 similar comments
+1 |
+1 |
+1 |
+1 It's been out for 3 months, would love official support for this. |
+1 |
This is fixed in develop, will be released in 6.2.4 in the next few weeks. |
@kball Does this mean Foundation's JS is compatible with jQuery 3, or does it mean that the version of jQuery that it ships with will be jQuery 3? For example in the node package, *node_modules\foundation-sites\vendor\jquery* |
Great question @olthof - as of now we're packaging up 2 still, but 3.0 is supposed to be slimmer and faster, so seems like perhaps we should upgrade the default. @colin-marshall @Owlbertz what are your thoughts? |
+1 |
Why is jquery shiped together with foundation? I never used it and even didn't know it's done this why. I think it would be best to let the user choose the version. Every packagemanager will handle the dependencies and if somebody isn't using a packagemanager he must be aware of the fact, that he needs to resolve dependencies by himself. |
JQuery is well known framework having a package manager will force Zurb to On Sun, Oct 2, 2016, 09:25 Daniel Schuba notifications@github.com wrote:
|
What were you referencing here?
6.2.4 is just recently bower-available, but an update still leaves us with jQuery 2x.
Can we get to F6 + jQuery 3 (yet)? This
suggests that FS 6.3.4 IS jQuery-ready, but at Bower update of Jquery
@SShrike committed
That commit was to the 6.2.4-rc. So is it supposed to be IN the 6.2.4 release already? |
No problems on the npm side. Probably a misconfiguration in bower.json? |
here's what I've got currently:
|
Have you tried deleting Also, |
Multiple times, as well as complete clean installs. Reproducible as above
Is that a comment to/for me? I certainly didn't add that ... manually anyway ... |
Closing this out since we have been using jQuery 3+ for awhile now. Feel free to reopen if you feel I have done so in error. |
This is not a bug, but a question / request.
Are there any plans in the near future to support jQuery 3 given that RC1 was just released recently? jQuery 3 has the same IE support (9+) as Foundation 6, so it would seem a good fit.
The text was updated successfully, but these errors were encountered: