remove leading '#' from captionLocation in foundation.orbit.js

[mattnworb]

If the caption for an orbit slider is set like

data-caption="#someDiv"

Then line 392 sets the id attribute of the element containing the caption to #someDiv.

This patch removes the leading # in the selector if it exists before applying it to the id attribute, so that any CSS rules designed to target a specific caption for a specific slider frame can work.

[mrsweaters]

looks good.

[alvinsiu]

From my download of Foundation 3 today, captions no longer show up because this patch removes the leading '#' in the selector before the captions contents are parsed. In "jquery.foundation.orbit.js," this is in lines 391-394.

Easy fix would be to put line 394 before line 391 so that the caption span is parsed before the leading '#' has been removed:

390. // if location selector starts with '#', remove it so we don't see id="#selector"
391. if (captionLocation.charAt(0) == '#') {
392.     captionLocation = captionLocation.substring(1, captionLocation.length);
393. }
394. captionHTML = $(captionLocation).html(); //get HTML from the matching HTML entity

I haven't tested to see if this breaks anything else, but it does fix the caption issues from "http://stackoverflow.com/questions/14058409/orbit-slider-captions-not-displaying" and "#1268."

[mattnworb]

@alvinsiu I think what you suggest makes a lot of sense. Sorry about any accidental breakages as a result of my fix.