Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Equalizer Responsive? Supporting Nested Equalizers by triggering based on Media Query #4882

Closed
oller opened this issue Apr 3, 2014 · 7 comments
Milestone

Comments

@oller
Copy link
Contributor

oller commented Apr 3, 2014

I'm using the handy equalizer js library, however I feel it could be extended to go further to support nested scenarios and to fire for certain media queries.

The use-case I have is that the grid layout is getting sufficiently complex that I have the need for nested Equalizers. So at desktop, I have 2 columns, which need to match height, then at mobile, I have 2 cols nested within one of those desktop columns which again need to match height. As it stands Equalizer doesn't support this.

One option would be to potentially add an additional media query flag to the data-equalizer-watch attribute, for example data-equalizer-watch="small" so you can selectively target which elements should be equalised and at what viewports.

Alternatively, leave all the watches as-is and set the flag on the parent data-equalizer i.e. data-equalizer="small", which would then either action or ignore the function.

Has anyone come across this limitation of equalizer? Any thoughts?

@oller oller changed the title Make Equalizer Responsive? Nested Equalizers Make Equalizer Responsive? Supporting Nested Equalizers by triggering based on Media Query Apr 3, 2014
@trevanhetzel
Copy link

I am in the same boat. I'm kind of shocked that it didn't come with media query support off the bat, since very rarely would you need equal heights on a one-column small screen layout. The need for equal heights tend to start around tablet size, when the columns are next to each other...

@thedeerchild
Copy link
Contributor

@trevanhetzel Equalizer only works on items that are next to each other. Equalizing is turned off when the columns fold under one another on small screens.

@winghouchan
Copy link
Contributor

@thedeerchild Not any more: #4978 😉

@winghouchan
Copy link
Contributor

I'll see if I can drum something up to make Equalizer responsive.

@rafibomb rafibomb added this to the Icebox milestone Jun 23, 2014
@LDigital84
Copy link

+1

@thedeerchild thedeerchild removed their assignment Aug 11, 2014
@stevesunderland
Copy link

👍

@rafibomb
Copy link
Member

This feature is not on our roadmap for Foundation Sites v5. We would however accept a PR for it. We'll close this here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants