Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other languages(korean..) isn't working after @3.7.2 #394

Closed
hyesung219 opened this issue Jan 20, 2020 · 2 comments
Closed

Other languages(korean..) isn't working after @3.7.2 #394

hyesung219 opened this issue Jan 20, 2020 · 2 comments

Comments

@hyesung219
Copy link

How can we reproduce this bug?

  1. Step one

Type @한글(korean)

What did you expect to happen?

Version @3.7.1 is working as I expected but not after.

What happened instead?
can't compositing one word when the mention function starts

https://codepen.io/gdev219/pen/RwNqoVE?editors=1010

Link (jsfiddle/plunkr/codepen) or Screenshot:
here is the working pen
FYI If you want to make a word or a character you have to make a combination with consonant(ㄱ,ㄴ,ㄷ,ㄹ ..) with vowel(ㅏ,ㅑ,ㅣ,ㅓ...)
After version 3.7.2 compositing a character isn't working at all.

Here is working pen.
https://codepen.io/gdev219/pen/RwNqoVE?editors=1010

Tribute-Debug-Template-Chrome-20

@hyojin
Copy link
Contributor

hyojin commented Jan 22, 2020

Hi @hyesung219
I'm facing the same issue and found that the new way of getting caret position breaks composition.
Not sure my PR will be merged or not but will send today or tomorrow.

hyojin added a commit to hyojin/tribute that referenced this issue Jan 23, 2020
* Get caret position from range instead of marker elem
mrsweaters pushed a commit that referenced this issue Feb 7, 2020
* Get caret position from range instead of marker elem
@mrsweaters
Copy link
Collaborator

Fixed in #394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants