Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : the highlighted item won't follow your cursor - bug #222

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

MrRobz
Copy link
Contributor

@MrRobz MrRobz commented Mar 22, 2019

fix for #221

@MrRobz
Copy link
Contributor Author

MrRobz commented Mar 29, 2019

@mrsweaters could you have a look !

@mrsweaters
Copy link
Collaborator

This looks good! The only issue I'm seeing is that it is loading the sourcemap in the dist/tribute.js instead of pointing to the dist/tribute.js.map file.

@MrRobz
Copy link
Contributor Author

MrRobz commented Mar 29, 2019

This looks good! The only issue I'm seeing is that it is loading the sourcemap in the dist/tribute.js instead of pointing to the dist/tribute.js.map file.

my bad I didn't push dist/tribute.min.js which has last line pointing to dist/tribute.js.map. Have updated now.

@MrRobz
Copy link
Contributor Author

MrRobz commented Mar 29, 2019

or do you want me to remove all the dist/ files from the PR?

@mrsweaters
Copy link
Collaborator

I'll do another build before release. Merging! Thank you!

@mrsweaters mrsweaters merged commit 65cfc8f into zurb:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants