Skip to content

Commit

Permalink
[MINOR] docs: modify the default value of `rss.coordinator.select.par…
Browse files Browse the repository at this point in the history
…tition.strategy` in docs (apache#1692)

### What changes were proposed in this pull request?
Modify the default value of rss.coordinator.select.partition.strategy in docs.

### Why are the changes needed?
The current document is wrong.

### Does this PR introduce any user-facing change?
No.

### How was this patch tested?
No need
  • Loading branch information
xianjingfeng committed May 11, 2024
1 parent 313d4e0 commit 8e26a34
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/client_guide/spark_client_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ and Continuous partition assignment mechanism.

It can be enabled by the following config
```bash
# Default value is ROUND, it will poll to allocate partitions to ShuffleServer
# Another value is ROUND, it will poll to allocate partitions to ShuffleServer
rss.coordinator.select.partition.strategy CONTINUOUS

# Default value is 1.0, used to estimate task concurrency, how likely is this part of the resource between spark.dynamicAllocation.minExecutors and spark.dynamicAllocation.maxExecutors to be allocated
Expand Down
2 changes: 1 addition & 1 deletion docs/coordinator_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ This document will introduce how to deploy Uniffle coordinators.
|rss.coordinator.remote.storage.io.sample.access.times|3| The number of times to read and write HADOOP FS files |
|rss.coordinator.startup-silent-period.enabled|false| Enable the startup-silent-period to reject the assignment requests for avoiding partial assignments. To avoid service interruption, this mechanism is disabled by default. Especially it's recommended to use in coordinator HA mode when restarting single coordinator. |
|rss.coordinator.startup-silent-period.duration|20000| The waiting duration(ms) when conf of rss.coordinator.startup-silent-period.enabled is enabled. |
|rss.coordinator.select.partition.strategy|ROUND| There are two strategies for selecting partitions: ROUND and CONTINUOUS. ROUND will poll to allocate partitions to ShuffleServer, and CONTINUOUS will try to allocate consecutive partitions to ShuffleServer, this feature can improve performance in AQE scenarios. |
|rss.coordinator.select.partition.strategy|CONTINUOUS| There are two strategies for selecting partitions: ROUND and CONTINUOUS. ROUND will poll to allocate partitions to ShuffleServer, and CONTINUOUS will try to allocate consecutive partitions to ShuffleServer, this feature can improve performance in AQE scenarios. |
|rss.metrics.reporter.class|-| The class of metrics reporter. |
|rss.reconfigure.interval.sec|5| Reconfigure check interval. |

Expand Down

0 comments on commit 8e26a34

Please sign in to comment.