feat: add pollValue API to perform get request for a specific ValueID #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
force-pushed
the
pollValue-API
branch
from
ea735f2
to
5f67028
Compare
|
@robertsLando Guess you'll need to expose this API too :) |
|
@zwave-js-bot pack this |
|
👋 Hey @AlCalzone! |
|
🎉 The packages have been published. |
|
Sure! Thanks @AlCalzone ! 🎉 |
|
Did you manage to make it so that N consecutive calls for a sleeping device is just 1 request in the end? (deduplication w/ queue) |
|
Not yet, that needs to be solved in general. I've raised #1482 to track that. |
|
Verified myself :) |
Closed
blhoward2
pushed a commit
to blhoward2/node-zwave-js
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
pollValuemethod on theZWaveNodeclass to performGETrequests for a specific value ID - similar to whatsetValueis forSETcommands.We still need to ensure that no redundant commands are queued, but that is something for another PR.