Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): import Z-Wave Alliance Files batch 1 #1619

Merged
merged 24 commits into from Feb 11, 2021
Merged

feat(config): import Z-Wave Alliance Files batch 1 #1619

merged 24 commits into from Feb 11, 2021

Conversation

blhoward2
Copy link
Collaborator

Batch 1 for volunteer review

@zwave-js-assistant zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Feb 6, 2021
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

@blhoward2
Copy link
Collaborator Author

@zwave-js-bot fix lint

warllo54
warllo54 suggested changes Feb 6, 2021
View reviewed changes
Copy link

@warllo54 warllo54 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't appear to allow me to make changes. I will go the route of forking your branch.

@blhoward2
Copy link
Collaborator Author

@warllo54 It doesn't look like you've made any changes to your fork. I'm going to handle this one as it has some popular devices in it.

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

ibddot
ibddot reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@ibddot ibddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for HS-FLS100-G2

packages/config/config/devices/0x000c/hs-fls100-g2.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x000c/hs-fls100-g2.json Outdated Show resolved Hide resolved
ibddot
ibddot reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@ibddot ibddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for LZW60

packages/config/config/devices/0x031e/lzw60.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x031e/lzw60.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x031e/lzw60.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x031e/lzw60.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x031e/lzw60.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x031e/lzw60.json Outdated Show resolved Hide resolved
@warllo54
Copy link

warllo54 commented Feb 9, 2021 via email

@blhoward2
Copy link
Collaborator Author

No worries. This one just had ones in that some people were waiting on.

blhoward2 and others added 8 commits February 9, 2021 21:47
@blhoward2 @ibddot
Update packages/config/config/devices/0x000c/hs-fls100-g2.json
55ae858 
Co-authored-by: ibddot <ibddot@yahoo.com>
@blhoward2 @ibddot
Update packages/config/config/devices/0x000c/hs-fls100-g2.json
804c620 
Co-authored-by: ibddot <ibddot@yahoo.com>
@blhoward2 @ibddot
Update packages/config/config/devices/0x031e/lzw60.json
8f602e6 
Co-authored-by: ibddot <ibddot@yahoo.com>
@blhoward2 @ibddot
Update packages/config/config/devices/0x031e/lzw60.json
1c46e76 
Co-authored-by: ibddot <ibddot@yahoo.com>
@blhoward2 @ibddot
Update packages/config/config/devices/0x031e/lzw60.json
57eed7b 
Co-authored-by: ibddot <ibddot@yahoo.com>
@blhoward2 @ibddot
Update packages/config/config/devices/0x031e/lzw60.json
fd200c3 
Co-authored-by: ibddot <ibddot@yahoo.com>
@blhoward2 @ibddot
Update packages/config/config/devices/0x031e/lzw60.json
2c8481b 
Co-authored-by: ibddot <ibddot@yahoo.com>
@blhoward2 @ibddot
Update packages/config/config/devices/0x031e/lzw60.json
e03c8da 
Co-authored-by: ibddot <ibddot@yahoo.com>
@zwave-js zwave-js deleted a comment from ibddot Feb 10, 2021
@zwave-js zwave-js deleted a comment from ibddot Feb 10, 2021
@blhoward2
Copy link
Collaborator Author

Some suggestions for HS-FLS100-G2

Thanks!

@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

1 similar comment
@zwave-js-assistant
Copy link

🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment
@zwave-js-bot fix lint

ibddot
ibddot suggested changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@ibddot ibddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels for HS-FLS100-G2 parameter 5 look backwards.

packages/config/config/devices/0x000c/hs-fls100-g2.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x000c/hs-fls100-g2.json Outdated Show resolved Hide resolved
blhoward2 and others added 2 commits February 9, 2021 23:35
@blhoward2 blhoward2 marked this pull request as ready for review February 10, 2021 04:36
AlCalzone
AlCalzone previously requested changes Feb 10, 2021
View reviewed changes
packages/config/config/devices/0x001d/zw15r.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x031e/lzw41.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x031e/lzw41.json Outdated Show resolved Hide resolved
packages/config/config/devices/0x031e/lzw41.json Outdated Show resolved Hide resolved
blhoward2 and others added 4 commits February 11, 2021 01:01
@blhoward2 @AlCalzone
Update packages/config/config/devices/0x001d/zw15r.json
640cd6e 
Co-authored-by: AlCalzone <d.griesel@gmx.net>
@blhoward2 @AlCalzone
Update packages/config/config/devices/0x031e/lzw41.json
c81f770 
Co-authored-by: AlCalzone <d.griesel@gmx.net>
@blhoward2 @AlCalzone
Update packages/config/config/devices/0x031e/lzw41.json
6440efa 
Co-authored-by: AlCalzone <d.griesel@gmx.net>
@blhoward2
Update lzw41.json
d1845b7 
values confirmed in the manual
@blhoward2 blhoward2 dismissed AlCalzone’s stale review February 11, 2021 06:06

changes made or values confirmed

@AlCalzone
Copy link
Member

Thanks everyone!

@AlCalzone AlCalzone merged commit 1b780e5 into zwave-js:master Feb 11, 2021
@blhoward2 blhoward2 deleted the batch1 branch February 11, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibddot ibddot ibddot requested changes

@warllo54 warllo54 warllo54 requested changes

@AlCalzone AlCalzone AlCalzone approved these changes

Assignees
No one assigned
Labels
config ⚙ Configuration issues or updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blhoward2 @warllo54 @AlCalzone @ibddot