fix(config): add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 #4345

cyrilst · 2022-03-09T21:59:15Z

Added missing parameters (35, 40, 41, 159 and 161).
Changed incorrect default values (for parameters 20 and 21).
Improved descriptions according to Fibaro documentation.
Changed On and Off case for consistency.

AlCalzone

Thanks, but your changes do not conform with our config file style guide. Please read through the section on config parameters and apply it.

Note that we already have some predefined templates, e.g. for the Scenes Sent, which should be used here. You can take a look at files for other similar Fibaro devices to see how they are used.

cyrilst · 2022-03-12T19:40:13Z

Thanks for the pointers @AlCalzone
Just updated the patch, don't hesitate to tell me if there is anything to improve.
When this patch will be ok, I'll update the FGS224 the same way.

AlCalzone

Thanks, much better. Just a few nits.

AlCalzone · 2022-03-12T20:24:20Z

packages/config/config/devices/0x010f/fgs214.json

-					"label": "Toggle switch (contact closed - On, contact opened - OFF)",
+					"label": "Toggle switch synchronized",
 					"value": 1
 				},
 				{
-					"label": "Toggle switch (device changes status when switch changes status)",
+					"label": "Toggle switch with memory",


I'm not 100% happy with these, the original is a bit verbose, but the shortened version is not self-explanatory. What about something along these lines?

value 1 -> "Toggle switch (synchronize output)"
value 2 -> "Toggle switch (toggle output)"

Indeed, that's way better.

AlCalzone · 2022-03-12T20:24:32Z

packages/config/config/devices/0x010f/fgs214.json

-					"label": "Toggle switch (contact closed - On, contact opened - OFF)",
+					"label": "Toggle switch synchronized",
 					"value": 1
 				},
 				{
-					"label": "Toggle switch (device changes status when switch changes status)",
+					"label": "Toggle switch with memory",


AlCalzone · 2022-03-12T20:26:18Z

packages/config/config/devices/0x010f/fgs214.json

 					"value": 1
 				},
 				{
-					"label": "Restore remembered state of relays after restoring power, but for toggle switches (parameter 20/21 set to 1) set the same state as the current state of the switches",
+					"label": "Same as switches",


I think this needs to mention the behavior when toggle switch (synchronized) is selected. Also "same as switches" is only true when param 20/21 is not set to 1.

Something like "Toggle switch (synchronize output): same as switches – other switch types: previous state"? I'm not convinced it's clear enough.

Lets do "Toggle switch (synchronize output): current switch state / Other switch types: previous state"

Ok, I just pushed the updated version.

…rt Module Added missing parameters (30-35, 40-41, 159 and 161). Changed incorrect default values (for parameters 20 and 21).

AlCalzone · 2022-03-12T21:28:22Z

LGTM. Do you want to do the FGS224 as part of this PR too?

cyrilst · 2022-03-12T21:32:03Z

Why not, the file will really look similar. Should I do a new commit for FGS224 in the same PR?

AlCalzone · 2022-03-12T21:36:21Z

Sure, go for it.

…ble Smart Module Added missing parameters (30-35, 40-41). Moved parameter 25 to 24 Moved parameter 26 to 25 Changed incorrect default values (for parameters 20 and 21).

cyrilst · 2022-03-12T22:35:22Z

Done. Maybe you should have a look at the last parameter (164). I changed the wording according to the style guide, but I'm not sure if it's self-explanatory.

### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v9) * The `route` parameter in `SendDataBridgeRequest` has been removed, since it isn't supported in any known SDK version (#3741) * Faster timeout while waiting for a response to a GET request (#3756) * Renamed properties and methods of the `Controller` class and related message classes (#3761) * Converted the `isControllerNode` method on the `ZWaveNode` class to a readonly property (#3972) * (possibly breaking) Upgraded `serialport` library to version 10.x (#4225) * The legacy network cache file `<homeid>.json` was converted to an appendonly `.jsonl` file in order to prevent data loss (#4263) ### Features * The node statistics now include RSSI and the actual routes taken (LWR, NLWR) for communication (#4022) * A utility method `rssiToString` was added to convert RSSI values to a human readable string * Export some commonly used string formatting utilities (#4318) * Add support for `Irrigation CC` (#4270) * The controller's `sdkVersion` property now includes the build number (or minor version) if supported (#4355) * Added a compat flag to expose received `MultilevelSwitchCCSet` commands via the `event` property (#4282) * Received `MultilevelSwitchCC` `Start/StopLevelChange` commands are now emitted as notifications (#4282) ### Bugfixes * Error reporting is now opt-in (#4279) and should no longer force-exit the application when an unhandled rejection occurs (#4291) * Increase the default controller response timeout to 10s to work around an issue where some 500 series controllers take too long to confirm execution of a SendData command when the target node is unresponsive (#4259) * Fix parsing of BridgeApplicationCommandRequest that do not contain an RSSI reading (#4337) * Fixed an issue with automatic clock correction where rounding the time up could lead to the clock being 1 hour late (#4346) * Notification event parameters containing a `UserCodeCC` report now correctly indicate the user ID again (#4356) ### Config file changes * Correct device description for Leviton DZMX1 (#4317) * Add metadata to Zooz ZSE18 (#4338) * Add metadata to AEON Labs DSB29 (#4334) * Add metadata to Vision Security GZ8101 (#4350) * Add metadata to AEON Labs DSC26 (#4343) * Add metadata to Ecolink DWZWAVE25 (#4339) * Merge redundant config files for Fibaro Walli Double Switch (#4370) * Add value 2 to Aeotec ZW100 param 81, FW 1.10-1.12 (#4361) * Add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 (#4345) * Correct value size for Zooz ZEN20 v2 (#4358) ### Changes under the hood * Lots of dependency updates * We no longer use `lerna` for monorepo management. It is largely unmaintained and doesn't support `yarn`'s `workspace:` protocol (#4071)

### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v9) * The `route` parameter in `SendDataBridgeRequest` has been removed, since it isn't supported in any known SDK version (#3741) * Faster timeout while waiting for a response to a GET request (#3756) * Renamed properties and methods of the `Controller` class and related message classes (#3761) * Converted the `isControllerNode` method on the `ZWaveNode` class to a readonly property (#3972) * (possibly breaking) Upgraded `serialport` library to version 10.x (#4225) * The legacy network cache file `<homeid>.json` was converted to an appendonly `.jsonl` file in order to prevent data loss (#4263) ### Features * The node statistics now include RSSI and the actual routes taken (LWR, NLWR) for communication (#4022) * A utility method `rssiToString` was added to convert RSSI values to a human readable string * Export some commonly used string formatting utilities (#4318) * Add support for `Irrigation CC` (#4270) * The controller's `sdkVersion` property now includes the build number (or minor version) if supported (#4355) * Added a compat flag to expose received `MultilevelSwitchCCSet` commands via the `event` property (#4282) * Received `MultilevelSwitchCC` `Start/StopLevelChange` commands are now emitted as notifications (#4282) * Added an `sdkVersion` property for nodes (#4371) ### Bugfixes * Error reporting is now opt-in (#4279) and should no longer force-exit the application when an unhandled rejection occurs (#4291) * Increase the default controller response timeout to 10s to work around an issue where some 500 series controllers take too long to confirm execution of a SendData command when the target node is unresponsive (#4259) * Fix parsing of BridgeApplicationCommandRequest that do not contain an RSSI reading (#4337) * Fixed an issue with automatic clock correction where rounding the time up could lead to the clock being 1 hour late (#4346) * Notification event parameters containing a `UserCodeCC` report now correctly indicate the user ID again (#4356) * Fixed an issue in the NVM migration routine that could lead to nonsensical radio settings which can only be changed by editing the NVM file manually (#4368) * Prevent infinite loop in health check when the node responds but there is no progress (#4372) * Route health checks can no longer have sleeping nodes as the target (#4373) * Lifeline health checks now wait for sleeping nodes to wake up instead of considering the wait time latency (#4376) * Route health check rounds now indicate when there were zero failed pings (#4377) ### Config file changes * Correct device description for Leviton DZMX1 (#4317) * Add metadata to Zooz ZSE18 (#4338) * Add metadata to AEON Labs DSB29 (#4334) * Add metadata to Vision Security GZ8101 (#4350) * Add metadata to AEON Labs DSC26 (#4343) * Add metadata to Ecolink DWZWAVE25 (#4339) * Merge redundant config files for Fibaro Walli Double Switch (#4370) * Add value 2 to Aeotec ZW100 param 81, FW 1.10-1.12 (#4361) * Add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 (#4345) * Correct value size for Zooz ZEN20 v2 (#4358) * Preserve all endpoints for Qubino ZMNKAD1 Luxy Smart Switch (#4366) ### Changes under the hood * Lots of dependency updates * We no longer use `lerna` for monorepo management. It is largely unmaintained and doesn't support `yarn`'s `workspace:` protocol (#4071)

### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v9) * The `route` parameter in `SendDataBridgeRequest` has been removed, since it isn't supported in any known SDK version (#3741) * Faster timeout while waiting for a response to a GET request (#3756) * Renamed properties and methods of the `Controller` class and related message classes (#3761) * Converted the `isControllerNode` method on the `ZWaveNode` class to a readonly property (#3972) * (possibly breaking) Upgraded `serialport` library to version 10.x (#4225) * The legacy network cache file `<homeid>.json` was converted to an appendonly `.jsonl` file in order to prevent data loss (#4263) ### Features * The node statistics now include RSSI and the actual routes taken (LWR, NLWR) for communication (#4022) * A utility method `rssiToString` was added to convert RSSI values to a human readable string * Export some commonly used string formatting utilities (#4318) * Add support for `Irrigation CC` (#4270) * The controller's `sdkVersion` property now includes the build number (or minor version) if supported (#4355) * Also expose `sdkVersion` on the controller node (#4388) * Added a compat flag to expose received `MultilevelSwitchCCSet` commands via the `event` property (#4282) * Received `MultilevelSwitchCC` `Start/StopLevelChange` commands are now emitted as notifications (#4282) * Added an `sdkVersion` property for nodes (#4371) * `LogContext` and related types are now exported (#4378) * Map `Basic CC Set` to appropriate CCs for devices with `Remote Switch` device class (#4382) * User codes and network keys are no longer logged (#4383) ### Bugfixes * Error reporting is now opt-in (#4279) and should no longer force-exit the application when an unhandled rejection occurs (#4291) * Increase the default controller response timeout to 10s to work around an issue where some 500 series controllers take too long to confirm execution of a SendData command when the target node is unresponsive (#4259) * Fix parsing of BridgeApplicationCommandRequest that do not contain an RSSI reading (#4337) * Fixed an issue with automatic clock correction where rounding the time up could lead to the clock being 1 hour late (#4346) * Notification event parameters containing a `UserCodeCC` report now correctly indicate the user ID again (#4356) * Fixed an issue in the NVM migration routine that could lead to nonsensical radio settings which can only be changed by editing the NVM file manually (#4368) * Prevent infinite loop in health check when the node responds but there is no progress (#4372) * Route health checks can no longer have sleeping nodes as the target (#4373) * Lifeline health checks now wait for sleeping nodes to wake up instead of considering the wait time latency (#4376) * Route health check rounds now indicate when there were zero failed pings (#4377) ### Config file changes * Correct device description for Leviton DZMX1 (#4317) * Add metadata to Zooz ZSE18 (#4338) * Add metadata to AEON Labs DSB29 (#4334) * Add metadata to Vision Security GZ8101 (#4350) * Add metadata to AEON Labs DSC26 (#4343) * Add metadata to Ecolink DWZWAVE25 (#4339) * Merge redundant config files for Fibaro Walli Double Switch (#4370) * Add value 2 to Aeotec ZW100 param 81, FW 1.10-1.12 (#4361) * Add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 (#4345) * Correct value size for Zooz ZEN20 v2 (#4358) * Preserve all endpoints for Qubino ZMNKAD1 Luxy Smart Switch (#4366) * Enable Multilevel Switch `event` value for Aeotec ZW111 (#4380) ### Changes under the hood * Lots of dependency updates * We no longer use `lerna` for monorepo management. It is largely unmaintained and doesn't support `yarn`'s `workspace:` protocol (#4071) * The bot now considers `zip` a valid extension for Z-Wave JS logfiles

### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v9) * The `route` parameter in `SendDataBridgeRequest` has been removed, since it isn't supported in any known SDK version (#3741) * Faster timeout while waiting for a response to a GET request (#3756) * Renamed properties and methods of the `Controller` class and related message classes (#3761) * Converted the `isControllerNode` method on the `ZWaveNode` class to a readonly property (#3972) * (possibly breaking) Upgraded `serialport` library to version 10.x (#4225) * The legacy network cache file `<homeid>.json` was converted to an appendonly `.jsonl` file in order to prevent data loss (#4263) ### Features * The node statistics now include RSSI and the actual routes taken (LWR, NLWR) for communication (#4022) * A utility method `rssiToString` was added to convert RSSI values to a human readable string * Export some commonly used string formatting utilities (#4318) * Add support for `Irrigation CC` (#4270) * The controller's `sdkVersion` property now includes the build number (or minor version) if supported (#4355) * Also expose `sdkVersion` on the controller node (#4388) * Added a compat flag to expose received `MultilevelSwitchCCSet` commands via the `event` property (#4282) * Received `MultilevelSwitchCC` `Start/StopLevelChange` commands are now emitted as notifications (#4282) * Added an `sdkVersion` property for nodes (#4371) * `LogContext` and related types are now exported (#4378) * Map `Basic CC Set` to appropriate CCs for devices with `Remote Switch` device class (#4382) * User codes and network keys are no longer logged (#4383) ### Bugfixes * Error reporting is now opt-in (#4279) and should no longer force-exit the application when an unhandled rejection occurs (#4291) * Increase the default controller response timeout to 10s to work around an issue where some 500 series controllers take too long to confirm execution of a SendData command when the target node is unresponsive (#4259) * Fix parsing of BridgeApplicationCommandRequest that do not contain an RSSI reading (#4337) * Fixed an issue with automatic clock correction where rounding the time up could lead to the clock being 1 hour late (#4346) * Notification event parameters containing a `UserCodeCC` report now correctly indicate the user ID again (#4356) * Fixed an issue in the NVM migration routine that could lead to nonsensical radio settings which can only be changed by editing the NVM file manually (#4368) * Prevent infinite loop in health check when the node responds but there is no progress (#4372) * Route health checks can no longer have sleeping nodes as the target (#4373) * Lifeline health checks now wait for sleeping nodes to wake up instead of considering the wait time latency (#4376) * Route health check rounds now indicate when there were zero failed pings (#4377) ### Config file changes * Correct device description for Leviton DZMX1 (#4317) * Add metadata to Zooz ZSE18 (#4338) * Add metadata to AEON Labs DSB29 (#4334) * Add metadata to Vision Security GZ8101 (#4350) * Add metadata to AEON Labs DSC26 (#4343) * Add metadata to Ecolink DWZWAVE25 (#4339) * Merge redundant config files for Fibaro Walli Double Switch (#4370) * Add value 2 to Aeotec ZW100 param 81, FW 1.10-1.12 (#4361) * Add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 (#4345) * Correct value size for Zooz ZEN20 v2 (#4358) * Preserve all endpoints for Qubino ZMNKAD1 Luxy Smart Switch (#4366) * Enable Multilevel Switch `event` value for Aeotec ZW111 (#4380) * Add metadata to AEON Labs DSB09 (#4391) ### Changes under the hood * Lots of dependency updates * We no longer use `lerna` for monorepo management. It is largely unmaintained and doesn't support `yarn`'s `workspace:` protocol (#4071) * The bot now considers `zip` a valid extension for Z-Wave JS logfiles * Added missing `toLogEntry` implementations (#4389) * Implemented a transformer-based codegen to auto-implement method argument checks based on types (#4394)

### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v9) * The `route` parameter in `SendDataBridgeRequest` has been removed, since it isn't supported in any known SDK version (#3741) * Faster timeout while waiting for a response to a GET request (#3756) * Renamed properties and methods of the `Controller` class and related message classes (#3761) * Converted the `isControllerNode` method on the `ZWaveNode` class to a readonly property (#3972) * (possibly breaking) Upgraded `serialport` library to version 10.x (#4225) * The legacy network cache file `<homeid>.json` was converted to an appendonly `.jsonl` file in order to prevent data loss (#4263) ### Features * The node statistics now include RSSI and the actual routes taken (LWR, NLWR) for communication (#4022) * A utility method `rssiToString` was added to convert RSSI values to a human readable string * Export some commonly used string formatting utilities (#4318) * Add support for `Irrigation CC` (#4270) * The controller's `sdkVersion` property now includes the build number (or minor version) if supported (#4355, #4398) * Also expose `sdkVersion` on the controller node (#4388) * Added a compat flag to expose received `MultilevelSwitchCCSet` commands via the `event` property (#4282) * Received `MultilevelSwitchCC` `Start/StopLevelChange` commands are now emitted as notifications (#4282) * Added an `sdkVersion` property for nodes (#4371) * `LogContext` and related types are now exported (#4378) * Map `Basic CC Set` to appropriate CCs for devices with `Remote Switch` device class (#4382) * User codes and network keys are no longer logged (#4383) ### Bugfixes * Error reporting is now opt-in (#4279) and should no longer force-exit the application when an unhandled rejection occurs (#4291) * Increase the default controller response timeout to 10s to work around an issue where some 500 series controllers take too long to confirm execution of a SendData command when the target node is unresponsive (#4259) * Fix parsing of BridgeApplicationCommandRequest that do not contain an RSSI reading (#4337) * Fixed an issue with automatic clock correction where rounding the time up could lead to the clock being 1 hour late (#4346) * Notification event parameters containing a `UserCodeCC` report now correctly indicate the user ID again (#4356) * Fixed an issue in the NVM migration routine that could lead to nonsensical radio settings which can only be changed by editing the NVM file manually (#4368) * Prevent infinite loop in health check when the node responds but there is no progress (#4372) * Route health checks can no longer have sleeping nodes as the target (#4373) * Lifeline health checks now wait for sleeping nodes to wake up instead of considering the wait time latency (#4376) * Route health check rounds now indicate when there were zero failed pings (#4377) * Multi Channel encapsulation now correctly uses V1 commands if this is the highest supported version of a node (#4387) ### Config file changes * Correct device description for Leviton DZMX1 (#4317) * Add metadata to Zooz ZSE18 (#4338) * Add metadata to AEON Labs DSB29 (#4334) * Add metadata to Vision Security GZ8101 (#4350) * Add metadata to AEON Labs DSC26 (#4343) * Add metadata to Ecolink DWZWAVE25 (#4339) * Merge redundant config files for Fibaro Walli Double Switch (#4370) * Add value 2 to Aeotec ZW100 param 81, FW 1.10-1.12 (#4361) * Add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 (#4345) * Correct value size for Zooz ZEN20 v2 (#4358) * Preserve all endpoints for Qubino ZMNKAD1 Luxy Smart Switch (#4366) * Enable Multilevel Switch `event` value for Aeotec ZW111 (#4380) * Add metadata to AEON Labs DSB09 (#4391) ### Changes under the hood * Lots of dependency updates * We no longer use `lerna` for monorepo management. It is largely unmaintained and doesn't support `yarn`'s `workspace:` protocol (#4071) * The bot now considers `zip` a valid extension for Z-Wave JS logfiles * Added missing `toLogEntry` implementations (#4389) * Implemented a transformer-based codegen to auto-implement method argument checks based on types (#4394, #4396) * In VSCode, the project now gets precompiled before running the test script (#4397)

### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v9) * The `route` parameter in `SendDataBridgeRequest` has been removed, since it isn't supported in any known SDK version (#3741) * Faster timeout while waiting for a response to a GET request (#3756) * Renamed properties and methods of the `Controller` class and related message classes (#3761) * Converted the `isControllerNode` method on the `ZWaveNode` class to a readonly property (#3972) * (possibly breaking) Upgraded `serialport` library to version 10.x (#4225) * The legacy network cache file `<homeid>.json` was converted to an appendonly `.jsonl` file in order to prevent data loss (#4263) * Almost all CC API methods now validate their arguments and will throw if they don't match the expected type (#4405) ### Features * The node statistics now include RSSI and the actual routes taken (LWR, NLWR) for communication (#4022) * A utility method `rssiToString` was added to convert RSSI values to a human readable string * Export some commonly used string formatting utilities (#4318) * Add support for `Irrigation CC` (#4270) * The controller's `sdkVersion` property now includes the build number (or minor version) if supported (#4355, #4398) * Also expose `sdkVersion` on the controller node (#4388) * Added a compat flag to expose received `MultilevelSwitchCCSet` commands via the `event` property (#4282) * Received `MultilevelSwitchCC` `Start/StopLevelChange` commands are now emitted as notifications (#4282) * Added an `sdkVersion` property for nodes (#4371) * `LogContext` and related types are now exported (#4378) * Map `Basic CC Set` to appropriate CCs for devices with `Remote Switch` device class (#4382) * User codes and network keys are no longer logged (#4383) ### Bugfixes * Error reporting is now opt-in (#4279) and should no longer force-exit the application when an unhandled rejection occurs (#4291) * Increase the default controller response timeout to 10s to work around an issue where some 500 series controllers take too long to confirm execution of a SendData command when the target node is unresponsive (#4259) * Fix parsing of BridgeApplicationCommandRequest that do not contain an RSSI reading (#4337) * Fixed an issue with automatic clock correction where rounding the time up could lead to the clock being 1 hour late (#4346) * Notification event parameters containing a `UserCodeCC` report now correctly indicate the user ID again (#4356) * Fixed an issue in the NVM migration routine that could lead to nonsensical radio settings which can only be changed by editing the NVM file manually (#4368) * Prevent infinite loop in health check when the node responds but there is no progress (#4372) * Route health checks can no longer have sleeping nodes as the target (#4373) * Lifeline health checks now wait for sleeping nodes to wake up instead of considering the wait time latency (#4376) * Route health check rounds now indicate when there were zero failed pings (#4377) * Multi Channel encapsulation now correctly uses V1 commands if this is the highest supported version of a node (#4387) * The versions of CCs that are not supported by the root device but only endpoints are now correctly queried (#4419) ### Config file changes * Correct device description for Leviton DZMX1 (#4317) * Add metadata to Zooz ZSE18 (#4338) * Add metadata to AEON Labs DSB29 (#4334) * Add metadata to Vision Security GZ8101 (#4350) * Add metadata to AEON Labs DSC26 (#4343) * Add metadata to Ecolink DWZWAVE25 (#4339) * Merge redundant config files for Fibaro Walli Double Switch (#4370) * Add value 2 to Aeotec ZW100 param 81, FW 1.10-1.12 (#4361) * Add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 (#4345) * Correct value size for Zooz ZEN20 v2 (#4358) * Preserve all endpoints for Qubino ZMNKAD1 Luxy Smart Switch (#4366) * Enable Multilevel Switch `event` value for Aeotec ZW111 (#4380) * Add metadata to AEON Labs DSB09 (#4391) * Correct value for Brightness After Power Failure for LZW31-SN (#4409) * Add value 3 to param 4 for Zooz Zen16 (#4404) * Add values for Alarm and Doorbell Sound Selection to Shenzhen Neo Siren Alarm (#4400) ### Changes under the hood * Lots of dependency updates * We no longer use `lerna` for monorepo management. It is largely unmaintained and doesn't support `yarn`'s `workspace:` protocol (#4071) * The bot now considers `zip` a valid extension for Z-Wave JS logfiles * Added missing `toLogEntry` implementations (#4389) * Implemented a transformer-based codegen to auto-implement method argument checks based on types (#4394, #4396) * In VSCode, the project now gets precompiled before running the test script (#4397)

Roughly nine months after the [last major release](https://github.com/zwave-js/node-zwave-js/releases/tag/v8.0.1), we've reached a new milestone. Z-Wave JS is now 4 years old, its usage has more than doubled over the course of the `v8.x` release line and it is still growing steadily. There are many exciting things yet to come, so stay tuned! ### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v9) * The `route` parameter in `SendDataBridgeRequest` has been removed, since it isn't supported in any known SDK version (#3741) * Faster timeout while waiting for a response to a GET request (#3756) * Renamed properties and methods of the `Controller` class and related message classes (#3761) * Converted the `isControllerNode` method on the `ZWaveNode` class to a readonly property (#3972) * (possibly breaking) Upgraded `serialport` library to version 10.x (#4225) * The legacy network cache file `<homeid>.json` was converted to an appendonly `.jsonl` file in order to prevent data loss (#4263) * Almost all CC API methods now validate their arguments and will throw if they don't match the expected type (#4405) ### Features * The node statistics now include RSSI and the actual routes taken (LWR, NLWR) for communication (#4022) * A utility method `rssiToString` was added to convert RSSI values to a human readable string * Export some commonly used string formatting utilities (#4318) * Add support for `Irrigation CC` (#4270) * The controller's `sdkVersion` property now includes the build number (or minor version) if supported (#4355, #4398) * Also expose `sdkVersion` on the controller node (#4388) * Added a compat flag to expose received `MultilevelSwitchCCSet` commands via the `event` property (#4282) * Received `MultilevelSwitchCC` `Start/StopLevelChange` commands are now emitted as notifications (#4282) * Added an `sdkVersion` property for nodes (#4371) * `LogContext` and related types are now exported (#4378) * Map `Basic CC Set` to appropriate CCs for devices with `Remote Switch` device class (#4382) * User codes and network keys are no longer logged (#4383) ### Bugfixes * Error reporting is now opt-in (#4279) and should no longer force-exit the application when an unhandled rejection occurs (#4291) * Increase the default controller response timeout to 10s to work around an issue where some 500 series controllers take too long to confirm execution of a SendData command when the target node is unresponsive (#4259) * Fix parsing of BridgeApplicationCommandRequest that do not contain an RSSI reading (#4337) * Fixed an issue with automatic clock correction where rounding the time up could lead to the clock being 1 hour late (#4346) * Notification event parameters containing a `UserCodeCC` report now correctly indicate the user ID again (#4356) * Fixed an issue in the NVM migration routine that could lead to nonsensical radio settings which can only be changed by editing the NVM file manually (#4368) * Prevent infinite loop in health check when the node responds but there is no progress (#4372) * Route health checks can no longer have sleeping nodes as the target (#4373) * Lifeline health checks now wait for sleeping nodes to wake up instead of considering the wait time latency (#4376) * Route health check rounds now indicate when there were zero failed pings (#4377) * Multi Channel encapsulation now correctly uses V1 commands if this is the highest supported version of a node (#4387) * The versions of CCs that are not supported by the root device but only endpoints are now correctly queried (#4419) ### Config file changes * Correct device description for Leviton DZMX1 (#4317) * Add metadata to Zooz ZSE18 (#4338) * Add metadata to AEON Labs DSB29 (#4334) * Add metadata to Vision Security GZ8101 (#4350) * Add metadata to AEON Labs DSC26 (#4343) * Add metadata to Ecolink DWZWAVE25 (#4339) * Merge redundant config files for Fibaro Walli Double Switch (#4370) * Add value 2 to Aeotec ZW100 param 81, FW 1.10-1.12 (#4361) * Add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 (#4345) * Correct value size for Zooz ZEN20 v2 (#4358) * Preserve all endpoints for Qubino ZMNKAD1 Luxy Smart Switch (#4366) * Enable Multilevel Switch `event` value for Aeotec ZW111 (#4380) * Add metadata to AEON Labs DSB09 (#4391) * Correct value for Brightness After Power Failure for LZW31-SN (#4409) * Add value 3 to param 4 for Zooz Zen16 (#4404) * Add values for Alarm and Doorbell Sound Selection to Shenzhen Neo Siren Alarm (#4400) ### Changes under the hood * Lots of dependency updates * We no longer use `lerna` for monorepo management. It is largely unmaintained and doesn't support `yarn`'s `workspace:` protocol (#4071) * The bot now considers `zip` a valid extension for Z-Wave JS logfiles * Added missing `toLogEntry` implementations (#4389) * Implemented a transformer-based codegen to auto-implement method argument checks based on types (#4394, #4396) * In VSCode, the project now gets precompiled before running the test script (#4397)

zwave-js-assistant bot added the config ⚙ Configuration issues or updates label Mar 9, 2022

AlCalzone requested changes Mar 10, 2022

View reviewed changes

cyrilst changed the title ~~fix(config): add parameters and correct descriptions for Fiabro Smart Module~~ fix(config): add parameters and correct default values for Fiabro Smart Module Mar 12, 2022

cyrilst force-pushed the patch-1 branch from 6a3db97 to 8dd5735 Compare March 12, 2022 19:26

AlCalzone requested changes Mar 12, 2022

View reviewed changes

fix(config): add parameters and correct default values for Fiabro Sma…

a2efd13

…rt Module Added missing parameters (30-35, 40-41, 159 and 161). Changed incorrect default values (for parameters 20 and 21).

cyrilst force-pushed the patch-1 branch from 8dd5735 to a2efd13 Compare March 12, 2022 21:17

AlCalzone changed the title ~~fix(config): add parameters and correct default values for Fiabro Smart Module~~ fix(config): add parameters and correct default values for Fibaro Smart Module Mar 12, 2022

AlCalzone previously approved these changes Mar 12, 2022

View reviewed changes

fix(config): add parameters and correct default values for Fiabro Dou…

c2f0c0b

…ble Smart Module Added missing parameters (30-35, 40-41). Moved parameter 25 to 24 Moved parameter 26 to 25 Changed incorrect default values (for parameters 20 and 21).

cyrilst dismissed AlCalzone’s stale review via c2f0c0b March 12, 2022 22:17

cyrilst changed the title ~~fix(config): add parameters and correct default values for Fibaro Smart Module~~ fix(config): add parameters and correct default values for Fibaro Smart Module and Double Smart Module Mar 12, 2022

AlCalzone approved these changes Mar 14, 2022

View reviewed changes

AlCalzone changed the title ~~fix(config): add parameters and correct default values for Fibaro Smart Module and Double Smart Module~~ fix(config): add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 Mar 14, 2022

AlCalzone merged commit 9200727 into zwave-js:master Mar 14, 2022

cyrilst deleted the patch-1 branch March 14, 2022 08:37

AlCalzone mentioned this pull request Mar 17, 2022

Fibaro FGS-2x4: Add alarm configuration parameters #1342

Closed

kpine mentioned this pull request Mar 30, 2022

Fibaro fgs224 missing parameters 40 & 41 home-assistant/core#68378

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(config): add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 #4345

fix(config): add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 #4345

cyrilst commented Mar 9, 2022

AlCalzone left a comment •

edited

cyrilst commented Mar 12, 2022

AlCalzone left a comment

AlCalzone Mar 12, 2022

cyrilst Mar 12, 2022

AlCalzone Mar 12, 2022

AlCalzone Mar 12, 2022

cyrilst Mar 12, 2022

AlCalzone Mar 12, 2022

cyrilst Mar 12, 2022

AlCalzone commented Mar 12, 2022

cyrilst commented Mar 12, 2022

AlCalzone commented Mar 12, 2022

cyrilst commented Mar 12, 2022

fix(config): add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 #4345

fix(config): add parameters and correct default values for Fibaro Smart Module FGS214 and Double Smart Module FGS224 #4345

Conversation

cyrilst commented Mar 9, 2022

AlCalzone left a comment • edited

Choose a reason for hiding this comment

cyrilst commented Mar 12, 2022

AlCalzone left a comment

Choose a reason for hiding this comment

AlCalzone Mar 12, 2022

Choose a reason for hiding this comment

cyrilst Mar 12, 2022

Choose a reason for hiding this comment

AlCalzone Mar 12, 2022

Choose a reason for hiding this comment

AlCalzone Mar 12, 2022

Choose a reason for hiding this comment

cyrilst Mar 12, 2022

Choose a reason for hiding this comment

AlCalzone Mar 12, 2022

Choose a reason for hiding this comment

cyrilst Mar 12, 2022

Choose a reason for hiding this comment

AlCalzone commented Mar 12, 2022

cyrilst commented Mar 12, 2022

AlCalzone commented Mar 12, 2022

cyrilst commented Mar 12, 2022

AlCalzone left a comment •

edited