-
-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): correct valueSize for param 15 on GE/Jasco 26931 / ZW4006 #4441
Conversation
I have 3 of these switches (I don't have any of the dimmer type). The motion timeout setting has not been working, finally realized this should be a valueSize of 2. Additionally it accepts values outside of the options, so I've removed the limit on manual entry and added a description. Tested and working well for my 3 of these devices.
Making schemantic commit for the bot
Note: I would guess this error is in all of the Jasco switches and dimmers with motion detectors. Links to potential other files with this same setup: |
@@ -242,7 +241,8 @@ | |||
"label": "27 mins", | |||
"value": 110 | |||
} | |||
] | |||
], | |||
"description": "Steps of 15 seconds for value 5 through 109" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the description below the label.
Any chance you've measured some of these? 😅
If I assume 5 is 60s, 6 is 75s, etc. then 108 is 27 minutes, 109 is 27m15s and 110 is 27m again? Seems odd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So ... they come out at 15 seconds after the first two.
1 -> 10 seconds
2 -> 20 seconds
3 -> 30 seconds
and 15 second steps from there. So actually 110 is 27 minutes plus 15 seconds. ((110*15-15)/60=27.25)
for values 3 and higher the equation for how many seconds is (value*15)-15
It's accurate for values of 2, 8, and 9 at least. The description of this one at z-wavealliance.org shows it best - confirming how it actually works...
I'll change it to that wording "15 second intervals, starting at 60 seconds" like it is in that link.
Updating to be *very* specific as it is [here](https://products.z-wavealliance.org/products/2093/configs)
Just "for science" I've run some tests. First at 2 minutes setting (value=9) // Initial trigger 7:48:05 AM
{"node":12,"nodeName":"AtticLight","nodeLocation":"SensorSwitch","event":"VALUE_UPDATED","timestamp":1649162885500,"object":{"commandClassName":"Notification","commandClass":113,"endpoint":0,"property":"Home Security","propertyKey":"Motion sensor status","newValue":8,"prevValue":0,"propertyName":"Home Security","propertyKeyName":"Motion sensor status"}}
// 2 minutes no motion 7:50:06 AM
{"node":12,"nodeName":"AtticLight","nodeLocation":"SensorSwitch","event":"VALUE_UPDATED","timestamp":1649163006375,"object":{"commandClassName":"Notification","commandClass":113,"endpoint":0,"property":"Home Security","propertyKey":"Motion sensor status","newValue":0,"prevValue":8,"propertyName":"Home Security","propertyKeyName":"Motion sensor status"}} Now running with the 110 value (27.25 minutes)... I'll update this comment once it goes back to idle. // Trigger for 27.25 minutes 7:50:57 AM:
{"node":12,"nodeName":"AtticLight","nodeLocation":"SensorSwitch","event":"VALUE_UPDATED","timestamp":1649163057307,"object":{"commandClassName":"Notification","commandClass":113,"endpoint":0,"property":"Home Security","propertyKey":"Motion sensor status","newValue":8,"prevValue":0,"propertyName":"Home Security","propertyKeyName":"Motion sensor status"}}
// 27.25 minute setting back to idle 8:18:18 AM :
{"node":12,"nodeName":"AtticLight","nodeLocation":"SensorSwitch","event":"VALUE_UPDATED","timestamp":1649164698287,"object":{"commandClassName":"Notification","commandClass":113,"endpoint":0,"property":"Home Security","propertyKey":"Motion sensor status","newValue":0,"prevValue":8,"propertyName":"Home Security","propertyKeyName":"Motion sensor status"}} With the little bit of "continued motion" at the start event, this comes out to be very close to 27.25 minutes, as expected. So now "yes" I've tested various situations including the maximum. Also tried setting to greater than 110, it does not take anything over 110. |
### Bugfixes * The door/latch/bolt status sensors are no longer created if unsupported by the door lock (#4448) * Fixed an issue where `securityClasses` in provisioning entries were returned as strings instead of their enum values (#4462) ### Config file changes * Add metadata to ZooZ ZEN26 (#4348) * Add metadata to ZooZ ZEN21 (#4349) * Add metadata to ZooZ ZEN27 (#4347) * Remove option 4 of LED Indicator Mode for Zooz ZSE40, FW 32.32+ (#4451) * Extend Heatit TF016 config to include TF021 (#4452) * Correct valueSize for param 15 on GE/Jasco 26931 / ZW4006 (#4441) * Add manual to GE/Jasco 26932 / 26933 / ZW3008 (#4446) * Correct reporting groups for Aeotec ZW132 Dual Nano Switch (#4447) * Removed the optional `min/maxValue` from many config files where the values were unnecessary or incorrect (#4455) ### Changes under the hood * Added documentation for the `Multilevel Switch CC` notifications (#4444)
I have 3 of these switches (I don't have any of the dimmer type). The motion timeout setting has not been working, finally realized this should be a valueSize of 2. Additionally it accepts values outside of the options, so I've removed the limit on manual entry and added a description. Tested and working well for my 3 of these devices.