fix(config): slightly clean up the Fibaro Motion Sensor config #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KTibow
changed the title
|
To correct correct the PR check. Change |
KTibow
changed the title
AlCalzone
requested changes
Jul 18, 2022
Comment on lines
129
to
132
| "description": "Sets the number of moves required (1-4) for the PIR sensor to report motion. The more the value is, the less sensitive it is.", | ||
| "valueSize": 1, | ||
| "minValue": 0, | ||
| "maxValue": 3, |
There was a problem hiding this comment.
The range in the description does not match the range defined by min/maxValue. I'm assuming the min/max is wrong, since 0 moves doesn't make sense.
Anyways, don't mention ranges in the description unless necessary.
There was a problem hiding this comment.
This means that when it's set to 0, 1 move is required, and when it's set to 3, 4 moves are required. Should I remove it to enhance clarity?
There was a problem hiding this comment.
Oh, I'd model this with options (and allowManualEntry: false) then.
value 0 => label 1
value 1 => label 2
etc.
| @@ -156,7 +173,7 @@ | |||
| "#": "6", | |||
| "$if": "firmwareVersion >= 3.2", | |||
| "label": "Motion detection - alarm cancellation delay", | |||
| "description": "Period of time after wich Motion alarm will be cancelled.", | |||
| "description": "Amount of time (seconds) the alarm will be canceled after.", | |||
There was a problem hiding this comment.
The unit should be specified using the "unit" property, not as part of the description.
| @@ -199,16 +216,40 @@ | |||
| "#": "9", | |||
| "$if": "firmwareVersion >= 3.2", | |||
| "label": "Motion detection - night/day", | |||
| "description": "The parameter defines the difference between night and day.", | |||
| "description": "The difference between night and day (lux), used in parameter #8.", | |||
There was a problem hiding this comment.
The unit should be specified using the "unit" property, not as part of the description.
Comment on lines
316
to
320
| "label": "Associations in Z-Wave network Security Mode", | ||
| "description": "This parameter defines how commands are sent in specified association groups", | ||
| "description": "This parameter defines in which association groups commands should be secure.", | ||
| "valueSize": 1, | ||
| "minValue": 0, | ||
| "maxValue": 15, |
There was a problem hiding this comment.
This entire parameter should be split like here:
node-zwave-js/packages/config/config/devices/0x010f/fgd212.json
Lines 385 to 409 in 08d0141
There was a problem hiding this comment.
I don't know that much about how you go about things here, should I just copy that into here?
There was a problem hiding this comment.
yeah you can basically copy this part, but update the firmwareVersion condition and the parameter no (27 should be 18 here)
| @@ -314,7 +355,7 @@ | |||
| "#": "22", | |||
| "$if": "firmwareVersion >= 3.2", | |||
| "label": "Tamper - alarm cancellation delay", | |||
| "description": "Time period after which a tamper alarm will be cancelled.", | |||
| "description": "Time period after which a tamper alarm will be cancelled (seconds).", | |||
There was a problem hiding this comment.
The unit should be specified using the "unit" property, not as part of the description.
| @@ -761,7 +803,7 @@ | |||
| "#": "86", | |||
| "$if": "firmwareVersion >= 3.2", | |||
| "label": "LED - temperature for blue colour", | |||
| "description": "Minimum temperature resulting in blue LED illumination", | |||
| "description": "When the temperature is below this (°C), the light is blue.", | |||
There was a problem hiding this comment.
The unit should be specified using the "unit" property, not as part of the description.
| @@ -741,7 +783,7 @@ | |||
| "#": "83", | |||
| "$if": "firmwareVersion >= 3.2", | |||
| "label": "LED - illuminance for high indicator brightness", | |||
| "description": "Light intensity level above which brightness of visual indicator is set to 100%.", | |||
| "description": "When the light intensity (lux) is above this, the brightness of the light is 1%.", | |||
There was a problem hiding this comment.
The unit should be specified using the "unit" property, not as part of the description.
| @@ -720,7 +762,7 @@ | |||
| "#": "82", | |||
| "$if": "firmwareVersion >= 3.2", | |||
| "label": "LED - illuminance for low indicator brightness", | |||
| "description": "Light intensity level below which brightness of visual indicator is set to 1%.", | |||
| "description": "When the light intensity (lux) is below this, the brightness of the light is 1%.", | |||
There was a problem hiding this comment.
The unit should be specified using the "unit" property, not as part of the description.
Comment on lines
702
to
744
| "description": "The parameter determines the brightness of LED when indicating motion.", | ||
| "description": "Percent brightness the LED lights up to.", |
There was a problem hiding this comment.
Remove description and add
"unit": "%",
please
| @@ -781,7 +823,7 @@ | |||
| "#": "87", | |||
| "$if": "firmwareVersion >= 3.2", | |||
| "label": "LED - temperature for red colour", | |||
| "description": "Minimum temperature resulting in red LED illumination", | |||
| "description": "When the temperature is above this (°C), the light is blue.", | |||
There was a problem hiding this comment.
The unit should be specified using the "unit" property, not as part of the description.
|
Should I work on updating the labels to be consistent, short, and use title case? |
Yeah, If you don't mind. I know this was meant as a partial improvement. |
|
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
AlCalzone
approved these changes
Jul 26, 2022
AlCalzone
changed the title
AlCalzone
added a commit
that referenced
this pull request
Jul 26, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically when supported and for more CCs than just `Multilevel Switch CC` (#4761) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832)
AlCalzone
added a commit
that referenced
this pull request
Aug 5, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically when supported and for more CCs than just `Multilevel Switch CC` (#4761) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880)
AlCalzone
added a commit
that referenced
this pull request
Aug 9, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically when supported and for more CCs than just `Multilevel Switch CC` (#4761) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697, #4892) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) ### Bugfixes (broken and fixed in v10 beta) * Emit value event after successful supervised `setValue` (#4899) * Correct nested encapsulation of Supervision CC Reports (#4890) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) * Correct param 9 for STEINEL devices, rework to templates (#4895) * Add Zooz Zen05 Outdoor Smart Plug (#4896) * Add MP31ZP (rebranded MP21ZP) (#4894) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880) * Move Supervision Session ID onto `ZWaveHost` interface (#4891)
AlCalzone
added a commit
that referenced
this pull request
Aug 10, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically when supported and for more CCs than just `Multilevel Switch CC` (#4761) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697, #4892) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) * Include both V1 values and V2+ values in `Notification CC` logs (#4904) * Obfuscate keys in `Entry Control CC` logs (#4905) ### Bugfixes (broken and fixed in v10 beta) * Emit value event after successful supervised `setValue` (#4899) * Correct nested encapsulation of Supervision CC Reports (#4890) * Ensure the `major.minor.patch` firmware version matches the legacy `major.minor` field before using it (#4906) * Move `"notification"` event args types back into `zwave-js` package (#4907) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) * Correct param 9 for STEINEL devices, rework to templates (#4895) * Add Zooz Zen05 Outdoor Smart Plug (#4896) * Add MP31ZP (rebranded MP21ZP) (#4894) * Update Zooz ZEN20 with additional parameters 28 - 36 (#4898) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880) * Move Supervision Session ID onto `ZWaveHost` interface (#4891)
AlCalzone
added a commit
that referenced
this pull request
Aug 15, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically when supported and for more CCs than just `Multilevel Switch CC` (#4761) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) with the possibility to override them for individual inclusion attempts (#4911) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697, #4892) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) * Allow overriding API key for the FW update service per call (#4912) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) * Include both V1 values and V2+ values in `Notification CC` logs (#4904) * Obfuscate keys in `Entry Control CC` logs (#4905) * Improved command flow for S2-encrypted communication when both parties transmit at the same time (#4900) ### Bugfixes (broken and fixed in v10 beta) * Emit value event after successful supervised `setValue` (#4899) * Correct nested encapsulation of Supervision CC Reports (#4890) * Ensure the `major.minor.patch` firmware version matches the legacy `major.minor` field before using it (#4906) * Move `"notification"` event args types back into `zwave-js` package (#4907) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) * Correct param 9 for STEINEL devices, rework to templates (#4895) * Add Zooz Zen05 Outdoor Smart Plug (#4896) * Add MP31ZP (rebranded MP21ZP) (#4894) * Update Zooz ZEN20 with additional parameters 28 - 36 (#4898) * Clean up branding of Jasco devices (#4873) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880) * Move Supervision Session ID onto `ZWaveHost` interface (#4891)
AlCalzone
added a commit
that referenced
this pull request
Aug 16, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically when supported and for more CCs than just `Multilevel Switch CC` (#4761) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) with the possibility to override them for individual inclusion attempts (#4911) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697, #4892) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) * Allow overriding API key for the FW update service per call (#4912) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) * Include both V1 values and V2+ values in `Notification CC` logs (#4904) * Obfuscate keys in `Entry Control CC` logs (#4905) * Improved command flow for S2-encrypted communication when both parties transmit at the same time (#4900) * Fixed a bug where commands that should be discarded because of a lower than expected security level would still store their values into the value DB (#4924) * Fixed looking up a node's provisioning entry using its node ID. This didn't work previously and would cause excluded SmartStart nodes to be included again immediately. (#4925) * No longer overwrite the security classes of a node when they are known for certain, and retry querying securely supported CCs during the interview (#4923) ### Bugfixes (broken and fixed in v10 beta) * Emit value event after successful supervised `setValue` (#4899) * Correct nested encapsulation of Supervision CC Reports (#4890) * Ensure the `major.minor.patch` firmware version matches the legacy `major.minor` field before using it (#4906) * Move `"notification"` event args types back into `zwave-js` package (#4907) * Fixed a typo in `AddNodeStatusContext`, which would result in an `UNKNOWN` device class of newly included nodes (#4922) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) * Correct param 9 for STEINEL devices, rework to templates (#4895) * Add Zooz Zen05 Outdoor Smart Plug (#4896) * Add MP31ZP (rebranded MP21ZP) (#4894) * Update Zooz ZEN20 with additional parameters 28 - 36 (#4898) * Clean up branding of Jasco devices (#4873) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880) * Move Supervision Session ID onto `ZWaveHost` interface (#4891)
AlCalzone
added a commit
that referenced
this pull request
Aug 22, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically when supported and for more CCs than just `Multilevel Switch CC` (#4761) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) with the possibility to override them for individual inclusion attempts (#4911) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697, #4892) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) * Allow overriding API key for the FW update service per call (#4912) * Support updating some driver options on the fly (#4930) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) * Include both V1 values and V2+ values in `Notification CC` logs (#4904) * Obfuscate keys in `Entry Control CC` logs (#4905) * Improved command flow for S2-encrypted communication when both parties transmit at the same time (#4900) * Fixed a bug where commands that should be discarded because of a lower than expected security level would still store their values into the value DB (#4924) * Fixed looking up a node's provisioning entry using its node ID. This didn't work previously and would cause excluded SmartStart nodes to be included again immediately. (#4925) * No longer overwrite the security classes of a node when they are known for certain, and retry querying securely supported CCs during the interview (#4923) ### Bugfixes (broken and fixed in v10 beta) * Emit value event after successful supervised `setValue` (#4899) * Correct nested encapsulation of Supervision CC Reports (#4890) * Ensure the `major.minor.patch` firmware version matches the legacy `major.minor` field before using it (#4906) * Move `"notification"` event args types back into `zwave-js` package (#4907) * Fixed a typo in `AddNodeStatusContext`, which would result in an `UNKNOWN` device class of newly included nodes (#4922) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) * Correct param 9 for STEINEL devices, rework to templates (#4895) * Add Zooz Zen05 Outdoor Smart Plug (#4896) * Add MP31ZP (rebranded MP21ZP) (#4894) * Update Zooz ZEN20 with additional parameters 28 - 36 (#4898) * Clean up branding of Jasco devices (#4873) * Add new 700 series Jasco devices (#4928) * Update description on several Jasco manufactured devices (#4927) * Apply compat flag to GreenWave PowerNode 5 (#4934) * Add wakeup instruction to Zooz ZEN34 (#4932) * Add parameter 15 Invert Output to Heatit Z-Temp2 (#4915) * Add Enbrighten 58438 / ZWA3016 (#4913) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880) * Move Supervision Session ID onto `ZWaveHost` interface (#4891)
AlCalzone
added a commit
that referenced
this pull request
Aug 24, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically for almost all CCs when supported (#4761, #4945) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) with the possibility to override them for individual inclusion attempts (#4911) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697, #4892) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) * Allow overriding API key for the FW update service per call (#4912) * Support updating some driver options on the fly (#4930) * Support correlating node responses to requests for which the ACK hasn't been received yet (#4946) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) * Include both V1 values and V2+ values in `Notification CC` logs (#4904) * Obfuscate keys in `Entry Control CC` logs (#4905) * Improved command flow for S2-encrypted communication when both parties transmit at the same time (#4900) * Fixed a bug where commands that should be discarded because of a lower than expected security level would still store their values into the value DB (#4924) * Fixed looking up a node's provisioning entry using its node ID. This didn't work previously and would cause excluded SmartStart nodes to be included again immediately. (#4925) * No longer overwrite the security classes of a node when they are known for certain, and retry querying securely supported CCs during the interview (#4923) * Increase wait time after firmware update and reset nonces before attempting communication (#4944) ### Bugfixes (broken and fixed in v10 beta) * Emit value event after successful supervised `setValue` (#4899) * Correct nested encapsulation of Supervision CC Reports (#4890) * Ensure the `major.minor.patch` firmware version matches the legacy `major.minor` field before using it (#4906) * Move `"notification"` event args types back into `zwave-js` package (#4907) * Fixed a typo in `AddNodeStatusContext`, which would result in an `UNKNOWN` device class of newly included nodes (#4922) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) * Correct param 9 for STEINEL devices, rework to templates (#4895) * Add Zooz Zen05 Outdoor Smart Plug (#4896) * Add MP31ZP (rebranded MP21ZP) (#4894) * Update Zooz ZEN20 with additional parameters 28 - 36 (#4898) * Clean up branding of Jasco devices (#4873) * Add new 700 series Jasco devices (#4928) * Update description on several Jasco manufactured devices (#4927) * Apply compat flag to GreenWave PowerNode 5 (#4934) * Add wakeup instruction to Zooz ZEN34 (#4932) * Add parameter 15 Invert Output to Heatit Z-Temp2 (#4915) * Add Enbrighten 58438 / ZWA3016 (#4913) * Add alarm mappings to ZSMOKE (#4942) * Add Zooz ZEN14 (#4921) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880) * Move Supervision Session ID onto `ZWaveHost` interface (#4891)
AlCalzone
added a commit
that referenced
this pull request
Aug 25, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically for almost all CCs when supported (#4761, #4945) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) with the possibility to override them for individual inclusion attempts (#4911) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697, #4892) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) * Allow overriding API key for the FW update service per call (#4912) * Support updating some driver options on the fly (#4930) * Support correlating node responses to requests for which the ACK hasn't been received yet (#4946) * `"notification"` events are now logged (#4948) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) * Include both V1 values and V2+ values in `Notification CC` logs (#4904) * Obfuscate keys in `Entry Control CC` logs (#4905) * Improved command flow for S2-encrypted communication when both parties transmit at the same time (#4900) * Fixed a bug where commands that should be discarded because of a lower than expected security level would still store their values into the value DB (#4924) * Fixed looking up a node's provisioning entry using its node ID. This didn't work previously and would cause excluded SmartStart nodes to be included again immediately. (#4925) * No longer overwrite the security classes of a node when they are known for certain, and retry querying securely supported CCs during the interview (#4923) * Increase wait time after firmware update and reset nonces before attempting communication (#4944) ### Bugfixes (broken and fixed in v10 beta) * Emit value event after successful supervised `setValue` (#4899) * Correct nested encapsulation of Supervision CC Reports (#4890) * Ensure the `major.minor.patch` firmware version matches the legacy `major.minor` field before using it (#4906) * Move `"notification"` event args types back into `zwave-js` package (#4907) * Fixed a typo in `AddNodeStatusContext`, which would result in an `UNKNOWN` device class of newly included nodes (#4922) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) * Correct param 9 for STEINEL devices, rework to templates (#4895) * Add Zooz Zen05 Outdoor Smart Plug (#4896) * Add MP31ZP (rebranded MP21ZP) (#4894) * Update Zooz ZEN20 with additional parameters 28 - 36 (#4898) * Clean up branding of Jasco devices (#4873) * Add new 700 series Jasco devices (#4928) * Update description on several Jasco manufactured devices (#4927) * Apply compat flag to GreenWave PowerNode 5 (#4934) * Add wakeup instruction to Zooz ZEN34 (#4932) * Add parameter 15 Invert Output to Heatit Z-Temp2 (#4915) * Add Enbrighten 58438 / ZWA3016 (#4913) * Add alarm mappings to ZSMOKE (#4942) * Add Zooz ZEN14 (#4921) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880) * Move Supervision Session ID onto `ZWaveHost` interface (#4891) * Add some `"silly"` logging to `handleNotificationReport` (#4949)
AlCalzone
added a commit
that referenced
this pull request
Aug 25, 2022
### Breaking changes · [Migration guide](https://zwave-js.github.io/node-zwave-js/#/getting-started/migrating-to-v10) * Dropped support for Node.js 12 (#4824, #4491) * Moved `Driver.interviewNode` method to the `ZWaveNode` class (#4823) * Added support to provide an API key for the firmware update service, soon mandatory (#4816) * Removed several deprecated things and reworked `beginExclusion` to use an options object instead (#4699) * CC implementations were moved into their own package (#4668) * CC code can now be used mostly without a driver instance (#4651) * Implement discoverable and transparently-typed CC value definitions instead of `getXYZValueId` methods (#4704) * `Supervision CC` is now used automatically for almost all CCs when supported (#4761, #4945) * Updated the argument type of the `"node found"` event to indicate that it is not an operational node (#4825) * S2 inclusion user callbacks were moved into `ZWaveOptions` (#4856) with the possibility to override them for individual inclusion attempts (#4911) * Node firmware versions are now exposed as `major.minor.patch` where supported (#4857) ### Features * Implement Z-Wave Protocol CC, for internal use (#4691) * Implemented mock controller and mock nodes to vastly improve how integration tests are written (#4697, #4892) * Add values to `Basic CC` and `Multilevel Switch CC` to restore previous non-zero level (#4732) * Answer incoming requests with the same encapsulation (#4832) * Allow passing a custom serial port implementation in `port` param of the Driver class (#4885) * Support sending `TimeCC` reports and automatically respond to requests (#4858) * Allow overriding API key for the FW update service per call (#4912) * Support updating some driver options on the fly (#4930) * Support correlating node responses to requests for which the ACK hasn't been received yet (#4946) * `"notification"` events are now logged (#4948) ### Bugfixes * Swap order of `destroy()` call and `Driver_Failed` error after restoring NVM (#4661) * Do not request ACK when sending node to sleep (#4826) * Correctly interpret powerlevel values as signed in `GetPowerlevelResponse` (#4827) * Add missing `reflect-metadata` dependency to some packages that were meant to be used standalone (#4846) * Fixed an off-by-one error while parsing the `supportedOperationTypes` bitmask of `User Code CC` (#4848) * Query user codes 1-by-1 if bulk reading is not supported (#4849) * Include both V1 values and V2+ values in `Notification CC` logs (#4904) * Obfuscate keys in `Entry Control CC` logs (#4905) * Improved command flow for S2-encrypted communication when both parties transmit at the same time (#4900) * Fixed a bug where commands that should be discarded because of a lower than expected security level would still store their values into the value DB (#4924) * Fixed looking up a node's provisioning entry using its node ID. This didn't work previously and would cause excluded SmartStart nodes to be included again immediately. (#4925) * No longer overwrite the security classes of a node when they are known for certain, and retry querying securely supported CCs during the interview (#4923) * Increase wait time after firmware update and reset nonces before attempting communication (#4944) ### Bugfixes (broken and fixed in v10 beta) * Emit value event after successful supervised `setValue` (#4899) * Correct nested encapsulation of Supervision CC Reports (#4890) * Ensure the `major.minor.patch` firmware version matches the legacy `major.minor` field before using it (#4906) * Move `"notification"` event args types back into `zwave-js` package (#4907) * Fixed a typo in `AddNodeStatusContext`, which would result in an `UNKNOWN` device class of newly included nodes (#4922) ### Config file changes * Corrected manufacturer and device labels for Heatit devices (#4838) * Slightly clean up the Fibaro Motion Sensor config (#4790) * Update Zooz ZEN17 to firmware 1.10 (#4809) * Add NewOne N4003, template more in the Minoston directory (#4834) * Add Fibaro Wall Plug UK - FGWPG-111 (#4865) * Correct param 9 for STEINEL devices, rework to templates (#4895) * Add Zooz Zen05 Outdoor Smart Plug (#4896) * Add MP31ZP (rebranded MP21ZP) (#4894) * Update Zooz ZEN20 with additional parameters 28 - 36 (#4898) * Clean up branding of Jasco devices (#4873) * Add new 700 series Jasco devices (#4928) * Update description on several Jasco manufactured devices (#4927) * Apply compat flag to GreenWave PowerNode 5 (#4934) * Add wakeup instruction to Zooz ZEN34 (#4932) * Add parameter 15 Invert Output to Heatit Z-Temp2 (#4915) * Add Enbrighten 58438 / ZWA3016 (#4913) * Add alarm mappings to ZSMOKE (#4942) * Add Zooz ZEN14 (#4921) ### Changes under the hood * Patch `tsserver` after install to allow displaying large types * Upgrade dependencies (#4820, #4663) * Make several reflection decorators generic and untangle `Manufacturer Proprietary CC` implementations (#4701) * Fixed typos throughout the project (#4837, #4842) * Added compliance tests for Z-Wave certification (#4832) * Removed a polyfill for `Object.entries` (#4859) * Added best practices for a reliable mesh to the docs (#4875) * Changes to the public API surface are now tracked using `@microsoft/api-extractor` (#4860) * Reorganized the CI jobs to only compile TypeScript once and reuse the build output during subsequent jobs (#4880) * Move Supervision Session ID onto `ZWaveHost` interface (#4891) * Add some `"silly"` logging to `handleNotificationReport` (#4949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes some stuff for the config in the fibaro motion sensor. Check the diff. It's still not consistent, but better than before.