feat: cache responses from firmware update service and queue requests #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
added a commit
that referenced
this pull request
Sep 9, 2022
### Features * Cache responses from firmware update service and queue requests (#5030) * Make user agent configurable and pass it to firmware update service (#5031) ### Bugfixes * Fixed an issue where `ThermostatModeCC` would save its values twice (#5019) * Ensure value ID received from outside code is valid and normalized before passing through (#5036) * Merge notification metadata for variables with multiple states (#5037) ### Changes under the hood * Added a test to ensure that `SupervisionCCReport` with status `Success` is always final, even if `more updates follow` is incorrectly set to `true` (#4963)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do so, we switched to
gotinstead ofaxios(hoping that they eventually upgradecacheable-request, so we can cache POST requests using built-in methods). By queueing and caching requests we should be able to avoid a lot of unnecessary requests. Caching is controlled by the firmware update service, but the cache kept in memory, so it is evicted by restarts.