Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Keyv instance directly as got request cache #5371

Merged
merged 1 commit into from
Jan 30, 2023
Merged

fix: use Keyv instance directly as got request cache #5371

merged 1 commit into from
Jan 30, 2023

Conversation

AlCalzone
Copy link
Member

fixes: #5369

@AlCalzone
Copy link
Member Author

@zwave-js-bot approve

@AlCalzone AlCalzone enabled auto-merge (squash) January 30, 2023 15:23
@AlCalzone AlCalzone merged commit 8d3c79f into master Jan 30, 2023
@AlCalzone AlCalzone deleted the keyv branch January 30, 2023 15:32
robertsLando
robertsLando reviewed Jan 30, 2023
View reviewed changes
packages/zwave-js/src/lib/controller/FirmwareUpdateService.ts
// create a new Keyv instance, causing event emitter warnings
// See https://github.com/jaredwray/cacheable-request/pull/101 for details
const requestCache = new Keyv();
requestCache.setMaxListeners(10000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, seems you are not passing requestCache anywhere here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-zwave-js/packages/zwave-js/src/lib/controller/FirmwareUpdateService.ts

Line 102 in 1da050b

cache: requestCache,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, missed that :)

AlCalzone added a commit that referenced this pull request Jan 30, 2023
@AlCalzone
chore: release v10.5.5
fbab6ee 
### Not really a feature
* Add 800 series chip types (#4910)

### Bugfixes
* Prevent "possible memory leak" warnings caused by `got` caching (#5371)
* When checking if a DSK is valid, also check its values, not only the format (#5376)

### Config file changes
* Define Lifeline association for Secure Meters SRT322 (#5370)
* Add ZVIDAR Z-DWS-V01, Z-DG-V01 and Sunricher SR-ZV9001T4-DIM (#5277)
* Disable Supervision for Minoston MP21Z (#5377)
* Add Quby Energy Meter Reader (#5379)
* Correct Zooz ZEN15 parameter 152 value size (#5378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando left review comments

@zwave-js-bot zwave-js-bot zwave-js-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in log pointing to possible memory leak
3 participants
@AlCalzone @robertsLando @zwave-js-bot