feat(config): add Dawon PM-S140-ZW, PM-S340-ZW and KR frequencies #5833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techinpark
changed the title
AlCalzone
requested changes
May 23, 2023
| { | ||
| "manufacturer": "Dawon", | ||
| "manufacturerId": "0x018c", | ||
| "label": "PM-S240-ZW", |
There was a problem hiding this comment.
I think this is supposed to be
Suggested change
| "label": "PM-S240-ZW", | |
| "label": "PM-S340-ZW", |
at least according to this comment I apparently never followed up.
Can this be?
There was a problem hiding this comment.
If that's the case, I suppose we should also add the other product types mentioned in #5132 (comment)
There was a problem hiding this comment.
@AlCalzone you right! 3 button type model is PM-S340-ZW 👍 6b2846c fixed here
techinpark
changed the title
|
Thanks! I'll hijack this PR to also add the 1-button variant and the other device IDs |
AlCalzone
changed the title
AlCalzone
previously approved these changes
May 23, 2023
AlCalzone
approved these changes
May 23, 2023
AlCalzone
added a commit
that referenced
this pull request
May 23, 2023
### Features * Add a value and API to control the indicator timeout (#5830) ### Bugfixes * Ignore inclusion notification for existing nodes (#5828) * Correct the serial API commands to set/get/delete priority routes (#5827) * Avoid crashing when the value DB contains a non-JSON key (#5829) ### Config file changes * Add LG U+ smart switches (#5835) * Add/correct config files for iSurpass J1825 (#5823) * Add fingerprint `0x0003:0x0042` to Kwikset 914C (#5834) * Add Dawon PM-S140-ZW, PM-S340-ZW and KR frequencies (#5833)
AlCalzone
added a commit
that referenced
this pull request
May 24, 2023
### Features * Add a value and API to control the indicator timeout (#5830) ### Bugfixes * Ignore inclusion notification for existing nodes (#5828) * Correct the serial API commands to set/get/delete priority routes (#5827) * Avoid crashing when the value DB contains a non-JSON key (#5829) ### Config file changes * Add LG U+ smart switches (#5835) * Add/correct config files for iSurpass J1825 (#5823) * Add fingerprint `0x0003:0x0042` to Kwikset 914C (#5834) * Add Dawon PM-S140-ZW, PM-S340-ZW and KR frequencies (#5833)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2-button device is registered, but the 3-button device is missing, so we created a PR to add it.
#5136 Related PR is here