fix: handle notification enum behavior "replace" correctly #6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zwave-js-bot automerge |
zwave-js-bot
approved these changes
Sep 15, 2023
AlCalzone
added a commit
that referenced
this pull request
Sep 21, 2023
### Bugfixes * Fixed an issue where some `Notification CC Reports` including an enumeration value would cause the corresponding value ID to be set to the wrong value (#6282) * When the Serial API on a controller restarts unexpectedly, the node ID length is now synchronized again (#6271) ### Config file changes * Add Heatit Z-TRM6 (#6263) * Increase poll delay for ZW500D (#6270) * Add fingerprint for Simon IO Master Roller Blind (#6262) * Add HOPPE eHandle ConnectSense (#6269) * Add parameters to Zooz ZEN17 from firmware 1.30 (#6189) * Update Zooz ZEN32 config to the latest firmware, include 800 series (#6283) * Add warnings about broken controller firmware versions (#6293) ### Changes under the hood * Some Z-Wave JS specific checks are now done using a custom ESLint plugin (#6276, #6279) * `yarn test` now only runs tests affected by changed files by default. This is also done on CI in PRs to speed up check times (#6274)
AlCalzone
added a commit
that referenced
this pull request
Sep 21, 2023
AlCalzone
added a commit
that referenced
this pull request
Sep 21, 2023
### Bugfixes * Fixed an issue where some `Notification CC Reports` including an enumeration value would cause the corresponding value ID to be set to the wrong value (#6282) * When the Serial API on a controller restarts unexpectedly, the node ID length is now synchronized again (#6271) ### Config file changes * Add warnings about broken controller firmware versions (#6293)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had a test for this, but the test didn't match the expectations explained in the comment.
fixes: #6281