Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): parameter update for Zooz Zen16 v2.0 #6569

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(config): parameter update for Zooz Zen16 v2.0 #6569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c80cfb0
fix(config): update zen16.json with extra parameters for v2.0
CodeOriginal Dec 26, 2023
112e300
fix(config): update zooz_template.json with values for zen16 v2.0
CodeOriginal Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
72 changes: 72 additions & 0 deletions packages/config/config/devices/0x027a/templates/zooz_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,78 @@
{
"label": "Garage door (momentary mode for Z-Wave control)",
"value": 3
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a new template, since those input types are only available in revision 2 (firmware 2.0+) of the switch.

{
"label": "Leak alarm (water sensor)",
"value": 4
},
{
"label": "Heat alarm",
"value": 5
},
{
"label": "Motion alert",
"value": 6
},
{
"label": "Open/close alert (door sensor)",
"value": 7
},
{
"label": "CO alarm",
"value": 8
},
{
"label": "CO2 alarm",
"value": 9
},
{
"label": "On/off report (dry contact switch/sensor)",
"value": 10
},
{
"label": "Relay - garage door mode; input - door sensor",
"value": 11
}
]
},
"zen16_switch_invert_v2": {
"valueSize": 1,
"defaultValue": 0,
"unsigned": true,
"allowManualEntry": false,
"options": [
{
"label": "Values not reversed",
"value": 0
},
{
"label": "Leak alarm (water sensor)",
"value": 4
},
{
"label": "Heat alarm",
"value": 5
},
{
"label": "Motion alert",
"value": 6
},
{
"label": "Open/close alert (door sensor)",
"value": 7
},
{
"label": "CO alarm",
"value": 8
},
{
"label": "CO2 alarm",
"value": 9
},
{
"label": "On/off report (dry contact switch/sensor)",
"value": 10
}
]
},
Expand Down
21 changes: 21 additions & 0 deletions packages/config/config/devices/0x027a/zen16.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@
"$import": "templates/zooz_template.json#zen16_switch_type_v2",
"label": "Switch 1: Type"
},
{
"#": "25",
"$if": "firmwareVersion >= 1.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"$if": "firmwareVersion >= 1.2",
"$if": "firmwareVersion >= 2.0",

Same for the other new parameters.

"$import": "templates/zooz_template.json#zen16_switch_invert_v2",
"label": "Switch 1: Invert Value",
"description": "Invert the reported values for your selected switch type in Sw1 terminals (select the same value as you chose for parameter 2 to invert the values for open and closed circuit)."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to keep descriptions as short as possible and avoid repeating the label in other words. Only use this if necessary to add additional information, e.g.

Suggested change
"description": "Invert the reported values for your selected switch type in Sw1 terminals (select the same value as you chose for parameter 2 to invert the values for open and closed circuit)."
"description": "Select the same value as in parameter 2 to invert the values for open and closed circuit."

Same for params 26/27

},
{
"#": "3",
"$if": "firmwareVersion <= 1.1",
Expand All @@ -86,6 +93,13 @@
"$import": "templates/zooz_template.json#zen16_switch_type_v2",
"label": "Switch 2: Type"
},
{
"#": "26",
"$if": "firmwareVersion >= 1.2",
"$import": "templates/zooz_template.json#zen16_switch_invert_v2",
"label": "Switch 2: Invert Value",
"description": "Invert the reported values for your selected switch type in Sw2 terminals (select the same value as you chose for parameter 3 to invert the values for open and closed circuit)."
},
{
"#": "4",
"$if": "firmwareVersion <= 1.1",
Expand All @@ -98,6 +112,13 @@
"$import": "templates/zooz_template.json#zen16_switch_type_v2",
"label": "Switch 3: Type"
},
{
"#": "27",
"$if": "firmwareVersion >= 1.2",
"$import": "templates/zooz_template.json#zen16_switch_invert_v2",
"label": "Switch 3: Invert Value",
"description": "Invert the reported values for your selected switch type in Sw3 terminals (select the same value as you chose for parameter 4 to invert the values for open and closed circuit)."
},
{
"#": "5",
"label": "LED Indicator",
Expand Down