feat(config): added Wave devices #6610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM. added wave_template
|
Thanks for this. I'll try to look at this when I find some time, as I'm currently on parental leave. |
|
Not the official reviewer, but it looks like the lint-zwave errors are from not using the lower case hex (i.e. 008a, not 008A, etc.) in five files. Also three files (001x16, 0a1p16, and 0a1x16) are duplicates? (same TYPE:ID and all versions) that could be a problem. Might want to check or combine into one with all the labels |
|
@apella12 |
|
There was mistakes, will make a new pull request. Closing this one. |
QubinoHelp
pushed a commit
to QubinoHelp/HA-node-zwave-js
that referenced
this pull request
Jan 23, 2024
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM added wave_template fixed errors from previous pull request feat(config): added Wave devices zwave-js#6610 Fixes reportd by the lint test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added Wave devices i4, i4DC, Plug UK, Plug US, PRO 1, PRO 2, PRO 2, PRO 2PM
added wave_template