Respect mandatory CCs defined for the device class #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
added
the
investigate 🔎
AlCalzone
changed the title
AlCalzone
added
CC
and removed
investigate 🔎
|
Some older devices leave out mandatory CCs from the NIF, so we actually need to do this. Coincidentally, this PR also includes some changes to the build system since it was necessary to fix it for this PR to work. |
AlCalzone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the way to go... OZW has to remove supported CCs in many config files. Probably better to just rely on the information the devices report us.
We could however use this when a device won't respond to a NIF request.
fixes: #674