fix: don't ping dead nodes before attempting communication #6944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
changed the title
|
@zwave-js-bot automerge |
zwave-js-bot
previously approved these changes
Jun 17, 2024
zwave-js-bot
approved these changes
Jun 17, 2024
AlCalzone
added a commit
that referenced
this pull request
Jun 17, 2024
### Bugfixes * Add compat flag to always encode Set-type commands using target node's CC version (#6918) * Export `NodeDump` type (#6915) * Redact secret values in `NodeDump` (#6934) * Added a workaround for devices that incorrectly send their `Binary Sensor Reports` using the sensor type `Any (0xff)`. Those reports are now interpreted as if they were using the first supported sensor type (#6933) * After adding an association to a LR node, Z-Wave JS no longer attempts assigning routes (#6936) * Removed some unnecessary log outputs during `rebuildNodeRoutes` when the node has no other associations than the controller (#6940) * Pings in route health checks no longer use explorer frames (#6942) * When attempting communication with a node that's considered dead, the command is now sent immediately instead of pinging first (#6944) * Fixed an issue where the priority and tag of a transaction would not be preserved when moving it to the wakeup queue (#6944) ### Config file changes * Remove endpoint workaround for Zooz ZEN30 800LR (#6931) * Encode CCs using target's CC version for `TKB Home TZ67` (#6918) ### Changes under the hood * GitHub links in the released `package.json` now point to the Z-Wave JS org (#6930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we no longer ping dead nodes before attempting the actual communication.
It didn't really achieve anything, as the ping still needs to be sent to the device. In case of failure, nothing is gained. In case of success, we had to send an additional command.