Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node command to send raw Config CC values #128

Merged
merged 5 commits into from Feb 23, 2021

Conversation

raman325
Copy link
Collaborator

@raman325 raman325 commented Feb 21, 2021

One of the goals for the HA set_config_parameter service is to allow users to send raw values for bitwise parameters that are either split out into partial parameters if they are defined in the device config or as a single value without any metadata if they are not. This PR adds a node command that we can use for those use cases.

Copy link
Collaborator

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Ok to merge when README updated.

@raman325
Copy link
Collaborator Author

@balloob seemed like there was an opportunity to improve the docs along with adding this command, so I went ahead and did so - let me know if you would like it to be formatted differently

Copy link
Collaborator

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me!

@MartinHjelmare MartinHjelmare merged commit ae8be9c into zwave-js:master Feb 23, 2021
@raman325 raman325 deleted the set_raw_config_cc branch February 23, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants