feat: zniffer

[robertsLando]

No description provided.

[coveralls]

Pull Request Test Coverage Report for Build 9298507831

Details

• 4 of 837 (0.48%) changed or added relevant lines in 13 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.6%) to 21.166%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
api/lib/SocketManager.ts	0	1	0.0%
api/config/store.ts	0	2	0.0%
src/components/nodes-table/nodes-table.js	0	2	0.0%
api/lib/SocketEvents.ts	0	3	0.0%
src/lib/SocketEvents.js	0	7	0.0%
src/lib/items.js	0	10	0.0%
src/router/index.js	0	11	0.0%
src/stores/base.js	0	33	0.0%
api/lib/utils.ts	4	62	6.45%
api/app.ts	0	103	0.0%

Files with Coverage Reduction	New Missed Lines	%
api/lib/SocketEvents.ts	1	0.0%

Totals
Change from base Build 9272143414:	-0.6%
Covered Lines:	3899
Relevant Lines:	19590

---

💛 - Coveralls

[AlCalzone]

I'll just put my thoughts here...

The settings for Zniffer should probably not offer the serial port that's already in use by the controller:

I don't think generating keys there makes sense, as you want to spy on an existing network with existing keys:

We may also have to consider setting them on the fly to retroactively decode some commands, but that will require support in the driver first.

[AlCalzone]

Filtering nodes makes sense in the table view but not in the settings IMO:

[robertsLando]

The settings for Zniffer should probably not offer the serial port that's already in use by the controller:

Yeah but what if the driver is disabled? (still have to add this option)

I don't think generating keys there makes sense, as you want to spy on an existing network with existing keys:

Should I drop keys from there and use the one set on driver? Or add a button to clone the ones on driver?

We may also have to consider setting them on the fly to retroactively decode some commands, but that will require support in the driver first.

👍🏼

Saving settings for the Zniffer should probably not restart the driver for the controller.

Yeah agree

There's an error in the devtools and nothing is being shown in the table:

That error happens because I'm using ZWaveFrameType that seems not exported in safe: https://github.com/zwave-js/zwave-js-ui/pull/3706/files#diff-71a3cb674c70b3fa9b3f52e9afc7d873f7d0eeefcbccb7175f1448a816811a99

[AlCalzone]

• Add a button to resume auto-scrolling

Am I blind? :)

[robertsLando]

@AlCalzone About the button I forgot to ask you what you mean because actually auto scroll is always enabled except if you have a frame opened in details, do you want to be able to re-enable it when you have a frame opened so?