Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a 'only connectivity matters' proof step #150

Closed
Tracked by #167
jvdwetering opened this issue Oct 19, 2023 · 0 comments · Fixed by #220
Closed
Tracked by #167

Make a 'only connectivity matters' proof step #150

jvdwetering opened this issue Oct 19, 2023 · 0 comments · Fixed by #220
Labels
Category: Proof mode Issues and enhancements related to Proof mode good first issue Good for newcomers Type: enhancement New feature or request

Comments

@jvdwetering
Copy link
Collaborator

Right now it is not possible to store movements in the plane as a proof step while in Proof mode. This means when you reload a saved proof that all the information about where the user moved the vertices is lost.

I suggest adding a button like 'save vertex positions as new proof step'.

@jvdwetering jvdwetering added the Type: enhancement New feature or request label Oct 19, 2023
@jvdwetering jvdwetering mentioned this issue Nov 4, 2023
3 tasks
@RazinShaikh RazinShaikh added the good first issue Good for newcomers label Nov 15, 2023
@jvdwetering jvdwetering added the Category: Proof mode Issues and enhancements related to Proof mode label Nov 27, 2023
wlcsm pushed a commit to wlcsm/zxlive that referenced this issue Dec 16, 2023
Previously we stored the proof as both a series of graphs and as an
initial graph together with a series of diffs. Now we have removed the
diffs to avoid possible synchronisation issues.

Additionally, the diffs did not record repositioned vertices, which made
adding an OCM step difficult (Issue: zxcalc#150)
wlcsm pushed a commit to wlcsm/zxlive that referenced this issue Dec 17, 2023
Previously we stored the proof as both a series of graphs and as an
initial graph together with a series of diffs. Now we have removed the
diffs to avoid possible synchronisation issues.

Additionally, the diffs did not record repositioned vertices, which made
adding an OCM step difficult (Issue: zxcalc#150)
wlcsm pushed a commit to wlcsm/zxlive that referenced this issue Dec 17, 2023
Previously we stored the proof as both a series of graphs and as an
initial graph together with a series of diffs. Now we have removed the
diffs to avoid possible synchronisation issues.

Additionally, the diffs did not record repositioned vertices, which made
adding an OCM step difficult (Issue: zxcalc#150)
RazinShaikh pushed a commit to wlcsm/zxlive that referenced this issue Jan 25, 2024
Previously we stored the proof as both a series of graphs and as an
initial graph together with a series of diffs. Now we have removed the
diffs to avoid possible synchronisation issues.

Additionally, the diffs did not record repositioned vertices, which made
adding an OCM step difficult (Issue: zxcalc#150)
RazinShaikh pushed a commit to wlcsm/zxlive that referenced this issue Jan 25, 2024
Previously we stored the proof as both a series of graphs and as an
initial graph together with a series of diffs. Now we have removed the
diffs to avoid possible synchronisation issues.

Additionally, the diffs did not record repositioned vertices, which made
adding an OCM step difficult (Issue: zxcalc#150)
@RazinShaikh RazinShaikh linked a pull request Jan 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Proof mode Issues and enhancements related to Proof mode good first issue Good for newcomers Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants