Add OCM step #220
Merged
Add OCM step #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested the PR but could you move the ocm button to the rules panel under the basic rules. |
Done 
|
added 3 commits
January 25, 2024 20:54
Previously we stored the proof as both a series of graphs and as an initial graph together with a series of diffs. Now we have removed the diffs to avoid possible synchronisation issues. Additionally, the diffs did not record repositioned vertices, which made adding an OCM step difficult (Issue: zxcalc#150)
Add a button on the toolbar to save the current graph as a separate OCM proof step. The button is always enabled, even when no changes have been made to the graph.
RazinShaikh
force-pushed
the
add-ocm-step
branch
from
edee5de
to
0f81919
Compare
RazinShaikh
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a button on the toolbar to save the current graph as a separate OCM proof step. Builds upon a previous PR #213
The button is always enabled however, even when no changes have been made to the graph. This would be a nice quality of life improvement, but with the way the ProofModel class is set up, it would involve littering button enables/disables throughout which is quite error prone. So I have not included it in this PR.