-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle to automatically connect new vertex to edge underneath it #337
Conversation
This is related to #311, but then kind of the converse. It is essentially the same feature as the 'magic slice' identity addition, but then using the tools native to the edit window. |
This is very hit or miss. Can you do something about that? snap-to-edge.mp4 |
I've mostly been dealing with this by zooming in more, so that the edge is wider. An alternative solution I was thinking of, was to make an edge you are hovering over more thick so that it is easier to click on it. |
…ith edges to snap vertex to edge
This now also implements #311. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
This is giving mypy a hard time:
we have |
# Conflicts: # zxlive/proof_panel.py
Hi @jvdwetering , thanks for merging this. For the next time, do you mind merging the PRs without squashing the commits. I think for a big PR like this, it is quite useful to have the full commit history for future reference/debugging instead of a single commit containing all the changes. |
Okay that makes sense. I wasn't sure what a good policy would be. |
Adds a button next to the Selection/Vertex/Edge buttons which when toggled makes the 'add vertex' automatically connect on an edge underneath it.
To make clear it snapped I added an animation to the edge, for which I added a new EItemAnimation class.