Fix iOS wrapper default hints' maxNumberOfSymbols #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axxel
added a commit
that referenced
this pull request
Feb 4, 2023
Explicitly setting `maxNumberOfSymbols` to 0 results in 0 detections which makes no sens in any case. Now we reinterpret 0 as `INT_MAX` which effectively means 'unlimited'. This is somewhat related to #507.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iOS wrapper,
ZXIDecodeHintsalready has a property ofmaxNumberOfSymbolsbut it is not synced with underlyingZXing::DecodeHints. It is used only to explicit set hints inZXIBarcodeReader.So because of default value of
NSIntegerin Objective-C is 0, if client does not explicitly set its value then reader will produce no result at all.This issue only happens if formats is set to
[ANY]or both[LINEAR_CODES, MATRIX_CODES]. It works just fine for single[LINEAR_CODES]format. I guess it related to some logics behind zxing-cpp.