Android wrapper: Modernize build files #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #555 |
okarmazin
force-pushed
the
android-modernization
branch
from
a399655
to
9d65b12
Compare
|
The main road-block that prevented #555 from moving forward is still there: https://github.com/zxing-cpp/zxing-cpp/actions/runs/6262637658/job/17005466542?pr=619#step:3:34 |
okarmazin
force-pushed
the
android-modernization
branch
from
9d65b12
to
51ecbf0
Compare
|
Updated the Java version used by the CI worker, should build now. |
|
Thanks, but apparently there is still something missing: https://github.com/zxing-cpp/zxing-cpp/actions/runs/6262900310/job/17006568650?pr=619 |
This commit updates the Android build files. No source files were changed.
Notable changes:
- Convert build scripts to Kotlin (build.gradle -> build.gradle.kts)
I tried to introduce this change incrementally to keep the build file history
tracked by Git, but was unable to do so.
- Kotlin 1.9.10
- Gradle 8.3, including the Gradle wrapper
- Use Gradle Version Catalog
- Android Gradle Plugin 8.1.1
okarmazin
force-pushed
the
android-modernization
branch
from
51ecbf0
to
4df2556
Compare
|
Right... Didn't know it was a required field. |
axxel
reviewed
Sep 21, 2023
|
Thanks for the contribution @okarmazin. I still want to overhaul the iOS wrapper someday very soon :) That's a nice push! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Android build files and updates project dependencies. No source files were changed.
I tried to introduce this change by incremental atomic commits to keep the build file history tracked by Git, but was unable to do so. The amount of changes required for the Kotlin script conversion was too great.
Notable changes: