Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required framework versions to MACOSX builds #624

Merged

Conversation

alexmanzer
Copy link
Contributor

With Xcode15 it is required, that frameworks must have in their Info.plist two (previously not needed) values: CFBundleShortVersionString and CFBundleVersion.

If they are missing, a build will be successful, but no upload to the AppStore is possible, it will fail with this error codes: Asset validation failed (90057)
Asset validation failed (90056)

Screenshot 2023-09-22 at 00 29 37

see https://stackoverflow.com/a/52298841 and
https://cmake.org/cmake/help/v3.0/prop_tgt/MACOSX_FRAMEWORK_INFO_PLIST.html

With Xcode15 it is required, that frameworks must have in their Info.plist two (previously not needed) values: CFBundleShortVersionString and CFBundleVersion.

If they are missing, a build will be successful, but no upload to the appstore is possible, it will fail with this error codes:
Asset validation failed (90057)
Asset validation failed (90056)

see https://stackoverflow.com/a/52298841 and
https://cmake.org/cmake/help/v3.0/prop_tgt/MACOSX_FRAMEWORK_INFO_PLIST.html
@axxel axxel merged commit a53b7a9 into zxing-cpp:master Oct 5, 2023
16 checks passed
@axxel
Copy link
Collaborator

axxel commented Oct 5, 2023

Thanks a lot.

@alexmanzer alexmanzer deleted the ios_fix_xcode15_build_and_upload branch October 6, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants