Support QR Code Model1 #633
Conversation
core/src/qrcode/QRDecoder.cpp
Outdated
| if (!formatInfo.isValid()) | ||
| return FormatError("Invalid format information"); | ||
|
|
||
| if (isModel1) |
There was a problem hiding this comment.
This split between reading version and reading format info is obviously not suitable anymore when those two inter-depend in the presence of Model1. I'll think about how I'd like this to be cleanup after merging.
|
As you can see, I thought the build failure can be fixed easily via the web-gui of github but it took me 4 tries to get everything. sigh. Now it builds but one test fails. If you could have look, that would be very nice. If not, I will then properly download your PR locally and debug it. Also, please replace the png you added with the one I provided earlier. I made an effort to make this file as small as possible (230 bytes vs 3.4kB). The test images use up way to much space and I try to limit the effect of any new addition. |
Supported QR code model 1
Although the source code is not very clean, you should be able to read all QR code model 1 with this.