Add support for Rectangular Micro QR Code (rMQR), pure only #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdingly; "rssexpanded-2/4_03.png" causes `assert(lineCount() == 1)` to trigger; also makes equals symmetrical
|
Awesome. Thank you very much. I would immediately merge this but the failed code128 writer test is a bit of a bummer. ;). Looking at the diff, the only thing I can see that could have cased this is the |
|
Just trying it out now...
…On Tue, Dec 5, 2023 at 10:07 PM axxel ***@***.***> wrote:
Awesome. Thank you very much. I would immediately merge this but the
failed code128 writer test
<https://github.com/zxing-cpp/zxing-cpp/actions/runs/7106943683/job/19347416134?pr=681#step:7:602>
is a bit of a bummer. ;). Looking at the diff, the only thing I can see
that could have cased this is the
add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>") line? Did this
work on your windows box?
—
Reply to this email directly, view it on GitHub
<#681 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADVVPTYIYGCXQ3Z6DUJDDDYH6LLTAVCNFSM6AAAAABAIL7XWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRGY4TONBRGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The What is your take on that? I can easily change that later myself. |
|
I'm easy - the term "rMQR" is used by the ISO/IEC document in the title so
it has some "official" status...
…On Tue, Dec 5, 2023 at 10:21 PM axxel ***@***.***> wrote:
The BarcodeFormat::rMQR does not quite fit into the list IMHO. I noticed
that the spec speaks of "Rectangular Micro QR Code (rMQR)" (which supports
your choice) but the Denso marketing term is rMQR Code
<https://www.denso-wave.eu/en/denso-products/rmqr-code> which would
translate to rMQRCode or maybe even RMQRCode and fits better into the
list of existing names, in my opinion.
What is your take on that? I can easily change that later myself.
—
Reply to this email directly, view it on GitHub
<#681 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADVVPUTBTMKYEJC2EDZQ4LYH6M5BAVCNFSM6AAAAABAIL7XWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRG4YTKNZUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
test passes on Windows (due to change to default UTF-8 in "test/unit/CMakeLists.txt" apparently); only needed to change the 3 tests with two instances in the one string but changed the others for consistency)
|
Ok the conversation's gotten out of sync but just made the change to
"RMQRCode" locally and yes, it does fit better in the list of existing
names. I can push the change if you like...
…On Tue, Dec 5, 2023 at 10:30 PM Martin Burke ***@***.***> wrote:
I'm easy - the term "rMQR" is used by the ISO/IEC document in the title so
it has some "official" status...
On Tue, Dec 5, 2023 at 10:21 PM axxel ***@***.***> wrote:
> The BarcodeFormat::rMQR does not quite fit into the list IMHO. I noticed
> that the spec speaks of "Rectangular Micro QR Code (rMQR)" (which supports
> your choice) but the Denso marketing term is rMQR Code
> <https://www.denso-wave.eu/en/denso-products/rmqr-code> which would
> translate to rMQRCode or maybe even RMQRCode and fits better into the
> list of existing names, in my opinion.
>
> What is your take on that? I can easily change that later myself.
>
> —
> Reply to this email directly, view it on GitHub
> <#681 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADVVPUTBTMKYEJC2EDZQ4LYH6M5BAVCNFSM6AAAAABAIL7XWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBRG4YTKNZUG4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
I changed it myself while adding all the wrapper copies of that as well (which are quite a few nowadays... ;)) I did a few quick tests with the android demo app and it actually works better than expected with real input. Very cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lineCount1 and swop calcs accordingly; "rssexpanded-2/4_03.png" causesassert(lineCount() == 1)to trigger; also makes equals symmetrical