Improve/rename start property

[odahcam]

Well, this property is a little confusing, my suggestion is to rename it to autostart and refactor the code to make less use of it. Also, methods should be included to start/stop scan and play/pause the preview.

If people still wants this property, I thikn it should be at least renamed to make it clear what it does. Also, there are implementations of the component property that reproduces strange behaviors.

[werthdavid]

Agree!

[odahcam]

Oh my god, this will have some impact on my develop branch and the v1.0 releases, I will try to create a new develop-v1.0 branch to avoid messing things up. Nice job btw.

[ilinkMat]

Will the play/pause preview feature be included in v1.1.0 ?

[odahcam]

Probably in v1.0.0. 😉

[ilinkMat]

Awesome work guys!
When would the v1.0.0 be released ?
Is there a way to pause the scanning and resume scanning when needed ?

[werthdavid]

Thanks!
Well... there's no ETA but we wanna release as soon as possible.
At this point you can't pause scanning directly you can only stop and start it, but when you stop it the preview is gone.
A workaround would be that when you pause scanning you just don't handle the scan-result. This is just a workaround since decoding takes place and generates CPU-load but oh well... 😉

Pseudo code:

<ngx-zxing [start]="cameraStarted" [device]="selectedDevice" (onCamsFound)="displayCameras($event)" (onScan)="handleQrCodeResult($event)"></ngx-zxing>

handleQrCodeResult(result: string): void {
  if(!this.paused) {
    console.log("My result is", result);
  }
}

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.