Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for 1D Barcodes #52

Closed
werthdavid opened this issue Mar 27, 2018 · 8 comments
Closed

Support for 1D Barcodes #52

werthdavid opened this issue Mar 27, 2018 · 8 comments
Labels
enhancement has PR This issue has at least one Pull Request that resolves it. P2 Issue that is important to resolve as soon as possible
Milestone
v2.0.0 - Fliperama

Comments

@werthdavid
Copy link
Member

After merging the PR #12 in the zxing-library, we will be able to detect 1D Barcodes as well. We should make the scanner fit for that as well

  • extending BrowserBarcodeReader if needed
  • at least update Wiki and Readme
@werthdavid werthdavid added enhancement not a bug future work Things that should be done in the future. labels Mar 27, 2018
@odahcam odahcam added this to the v2.0.0 - Fliperama milestone Mar 27, 2018
@odahcam
Copy link
Member

odahcam commented Mar 27, 2018

So, I would go with a new option, like: 1d, 2d, both for performance reasons. So we could select the appropriated reader class in the BrowserBarcodeReader. 🤔

@werthdavid
Copy link
Member Author

Yepp! I'm using ZXing on Android/Java, there you have constants for the different barcode-types and you can then define which codes are to be detected

@odahcam odahcam added the P2 Issue that is important to resolve as soon as possible label Apr 5, 2018
@odahcam
Copy link
Member

odahcam commented Apr 9, 2018

News: zxing-js/library#12 has merged!

werthdavid added a commit that referenced this issue Apr 16, 2018
@werthdavid
#52 Support for 1D Barcodes in Readme
f3b741e
@susannaHayrapetyan
Copy link

Hi, when we can use this feature? is it available now? I see it's not working for demo apps you have provided in readme.

@odahcam odahcam added the PRs welcome Community can make a PR for this change. label May 2, 2018
@odahcam
Copy link
Member

odahcam commented May 2, 2018

Helo! This is scheduled to be in a future release. It's already available in https://github.com/zxing-js/library but we didn't integrate the new reader in here yet.

@werthdavid
Copy link
Member Author

Can we close this now @odahcam ?

@odahcam
Copy link
Member

odahcam commented May 17, 2018

I don't think so, because I didn't implemented anything here to use the new library's reader. Let's wait until our first 1D barcode read. :)

@odahcam odahcam added has PR This issue has at least one Pull Request that resolves it. and removed PRs welcome Community can make a PR for this change. future work Things that should be done in the future. not a bug labels Jun 27, 2018
@odahcam odahcam closed this as completed Aug 11, 2018
@lock
Copy link

lock bot commented Aug 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement has PR This issue has at least one Pull Request that resolves it. P2 Issue that is important to resolve as soon as possible
Projects
None yet
Milestone
v2.0.0 - Fliperama
Development

No branches or pull requests
3 participants
@odahcam @werthdavid @susannaHayrapetyan