Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandLineRunner --raw option is broken for PDF_417 barcodes #1682

Closed
dlenski opened this issue Sep 7, 2023 · 0 comments · Fixed by #1683
Closed

CommandLineRunner --raw option is broken for PDF_417 barcodes #1682

dlenski opened this issue Sep 7, 2023 · 0 comments · Fixed by #1683
Assignees
@dlenski
Labels
bug
Milestone
3.5.3

Comments

@dlenski
Copy link
Contributor

dlenski commented Sep 7, 2023 •
edited
Loading

PDF_417 barcodes (and maybe other types as well) will break the --raw option, apparently because their com.google.zxing.Result method getRawBytes() returns null.

Using v3.5.1 and the test/barcodes/PDF_417-easy.bmp from https://github.com/dlenski/python-zxing as an example:

$ java -cp 'core.jar:javase.jar:jcommander.jar' com.google.zxing.client.j2se.CommandLineRunner PDF_417-easy.bmp --raw
Exception in thread "main" java.lang.NullPointerException
	at com.google.zxing.client.j2se.DecodeWorker.decode(DecodeWorker.java:172)
	at com.google.zxing.client.j2se.DecodeWorker.call(DecodeWorker.java:76)
	at com.google.zxing.client.j2se.CommandLineRunner.main(CommandLineRunner.java:99)

The error is coming from here:

zxing/javase/src/main/java/com/google/zxing/client/j2se/DecodeWorker.java

Lines 172 to 175 in 557b5fc

for (byte b : result.getRawBytes()) {
rawData.append(String.format("%02X", b & 0xff));
rawData.append(" ");
}

The --raw option was added in 83650ce
@dlenski dlenski mentioned this issue Sep 7, 2023
Merged
dlenski added a commit to dlenski/python-zxing that referenced this issue Sep 7, 2023
@dlenski
The ZXing v3.5.0+ --raw option is broken for PDF_417 barcodes
11de2c6 
The combination of '--raw' with certain barcode types, including PDF_417, is
broken: CommandLineRunner will fail with NullPointerException.

See zxing/zxing#1682 for more details.
dlenski added a commit to dlenski/python-zxing that referenced this issue Sep 7, 2023
@dlenski
The ZXing v3.5.0+ --raw option is broken for PDF_417 barcodes
6f36af9 
The combination of '--raw' with certain barcode types, including PDF_417, is
broken: CommandLineRunner will fail with NullPointerException.

See zxing/zxing#1682 for more details.
srowen pushed a commit that referenced this issue Sep 7, 2023
@dlenski
Prevent --raw CLR option from failing if result.getRawBytes() is null (…
672bd40 
…#1683)

Fixes #1682
@srowen srowen added the bug label Sep 7, 2023
@srowen srowen added this to the 3.5.3 milestone Sep 7, 2023
dlenski added a commit to dlenski/python-zxing that referenced this issue Sep 21, 2023
@dlenski
The ZXing v3.5.0+ --raw option is broken for PDF_417 barcodes
0512c7a 
The combination of '--raw' with certain barcode types, including PDF_417, is
broken: CommandLineRunner will fail with NullPointerException.

See zxing/zxing#1682 for more details.
dlenski added a commit to dlenski/python-zxing that referenced this issue Nov 2, 2023
@dlenski
Don't use ZXing's --raw option except with v3.5.3+
07d94c5 
(This probably should have been done as part of 0512c7a.)

The --raw option was added in 3.5.0, but broken for certain barcode types
(PDF_417 and maybe others) until 3.5.3: CommandLineRunner will fail with
NullPointerException.

See zxing/zxing#1682 and
zxing/zxing#1683 for more details.
@dlenski dlenski mentioned this issue Jan 31, 2024
Open
dlenski added a commit to dlenski/python-zxing that referenced this issue Feb 20, 2024
@dlenski
use latest ZXing release (3.5.3)
2625eb0 
Among other improvements, this release of ZXing fixes the brokenness of the
`--raw` option (added in 3.5.0, but broken for `PDF_417` and maybe other
barcode types). See my bug report and fix for that issue at
zxing/zxing#1682 and
zxing/zxing#1683.
dlenski added a commit to dlenski/python-zxing that referenced this issue Feb 20, 2024
@dlenski
use latest ZXing release (3.5.3)
646766b 
Among other improvements, this release of ZXing fixes the brokenness of the
`--raw` option (added in 3.5.0, but broken for `PDF_417` and maybe other
barcode types). See my bug report and fix for that issue at
zxing/zxing#1682 and
zxing/zxing#1683.
@dlenski dlenski mentioned this issue Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlenski dlenski

Labels
bug
Milestone
3.5.3
Development

Successfully merging a pull request may close this issue.

Prevent --raw CLR option from failing if result.getRawBytes() is null
2 participants
@dlenski @srowen