Prevent --raw CLR option from failing if result.getRawBytes() is null #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Sep 7, 2023
|
Looks good, thanks! |
dlenski
added a commit
to dlenski/python-zxing
that referenced
this pull request
Nov 2, 2023
(This probably should have been done as part of 0512c7a.) The --raw option was added in 3.5.0, but broken for certain barcode types (PDF_417 and maybe others) until 3.5.3: CommandLineRunner will fail with NullPointerException. See zxing/zxing#1682 and zxing/zxing#1683 for more details.
dlenski
added a commit
to dlenski/python-zxing
that referenced
this pull request
Feb 20, 2024
Among other improvements, this release of ZXing fixes the brokenness of the `--raw` option (added in 3.5.0, but broken for `PDF_417` and maybe other barcode types). See my bug report and fix for that issue at zxing/zxing#1682 and zxing/zxing#1683.
dlenski
added a commit
to dlenski/python-zxing
that referenced
this pull request
Feb 20, 2024
Among other improvements, this release of ZXing fixes the brokenness of the `--raw` option (added in 3.5.0, but broken for `PDF_417` and maybe other barcode types). See my bug report and fix for that issue at zxing/zxing#1682 and zxing/zxing#1683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1682