Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: fix amalgamation public header warning #440

Merged
merged 1 commit into from May 21, 2023

Conversation

athre0z
Copy link
Member

@athre0z athre0z commented May 20, 2023

The previous code would mix up absolute and relative paths to determine when to print the warning about public headers first being encountered when processing the source files. This commit fixes this and thus gets rid of the incorrect warnings.

The previous code would mix up absolute and relative paths to determine
when to print the warning about public headers first being encountered
when processing the source files. This commit fixes this and thus gets
rid of the incorrect warnings.
@athre0z athre0z added C-bug Category: This is a bug (or a fix for a bug, when applied to PRs) P-low Priority: Low A-build Area: Build system labels May 20, 2023
@athre0z athre0z requested a review from flobernd May 20, 2023 17:10
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@athre0z athre0z merged commit e5f4a86 into master May 21, 2023
13 checks passed
@athre0z athre0z deleted the fix-amalgamate-warning branch May 21, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: Build system C-bug Category: This is a bug (or a fix for a bug, when applied to PRs) P-low Priority: Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants