Added support for z/OS. #3289
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ require ( | |
| github.com/dustin/go-humanize v1.0.0 | ||
| github.com/go-errors/errors v1.0.1 | ||
| github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 | ||
| github.com/mattn/go-isatty v0.0.16 | ||
| github.com/mattn/go-runewidth v0.0.7 | ||
| github.com/mitchellh/go-homedir v1.1.0 | ||
| github.com/sergi/go-diff v1.1.0 | ||
|
|
@@ -14,7 +14,7 @@ require ( | |
| github.com/zyedidia/clipper v0.1.1 | ||
| github.com/zyedidia/glob v0.0.0-20170209203856-dd4023a66dc3 | ||
| github.com/zyedidia/json5 v0.0.0-20200102012142-2da050b1a98d | ||
| github.com/zyedidia/tcell/v2 v2.0.10 | ||
|
There was a problem hiding this comment. Slightly unrelated to the PR, right? There was a problem hiding this comment. I don't think I made this change. I think the build did. Does it have an effect? There was a problem hiding this comment. I suggest to stay with the current content, as long as it isn't really needed here. @dmaluka: There was a problem hiding this comment. I'm not really familiar with this particular aspect of Go. But I agree it doesn't look like we should change this tcell line. |
||
| github.com/zyedidia/terminal v0.0.0-20230315200948-4b3bcf6dddef | ||
| golang.org/x/text v0.3.8 | ||
| gopkg.in/yaml.v2 v2.2.8 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| // +build linux darwin dragonfly solaris openbsd netbsd freebsd zos | ||
|
There was a problem hiding this comment. What about... ...? Hm curious, There was a problem hiding this comment. @JoeKar, yeah I'm not sure exactly what is going on there. The only use of RunTermEmulator I could find is in the fzf plugin (https://github.com/micro-editor/updated-plugins/blob/master/fzf/main.lua). It checks for shell.TermEmuSupported and if run invokes shell.RunTermEmulator, otherwise invokes shell.RunInteractiveShell. And if shell.RunInteractiveShell fails it invokes (local) fzfOutput. The plugin works without any source change. I think it's working with RunInteractiveShell. But I really don't understand why. If I add zos to build for terminal_supported.go and !zos for terminal_unsupported.go I get "Unsupported operating system". Which makes no sense to me, since that message is in terminal_unsupported.go, which it shouldn't be building. Since it is working with no changes I figured I'd deal with it later. But if you have any ideas, that would be great. There was a problem hiding this comment. It's relevant here... micro/internal/action/termpane.go Line 63 in 1f51d0b ...and here too... micro/internal/action/command.go Line 965 in 1f51d0b Have you really build with |
||
|
|
||
| package action | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, due to the fact that it was introduced with mattn/go-isatty@360bbd2 in v0.0.13 first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think I should change it to v.0.0.13? I didn't see that in some list I saw somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually I've no problem to update to the latest tag, but above
v0.0.17we would loose the documentedgocompatibility ofv1.16due to the dependency ofgolang.org/x/sys. At least as far as I understood.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the update you should squash your last 5 commits and correct the commit description, since you switched from
v0.0.16tov0.0.13.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not positive, but I think I've done this. (I'm not a power user of git.)