-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components/input-number): convert directive to component #727
Conversation
Visit the preview URL for this PR (updated for commit 60f271a): https://prizm-v3--pr727-feat-input-number-wlh5nxjt.web.app (expires Mon, 23 Oct 2023 07:53:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6cf3db9b3e1bf46180849c1db2e28221d0904ddf |
Visit the preview URL for this PR (updated for commit 60f271a): https://prizm-v1--pr727-feat-input-number-1s3sqoyj.web.app (expires Mon, 23 Oct 2023 07:55:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 3f40bac4652dbd13be483e7e4de02de469ed4b3f |
Visit the preview URL for this PR (updated for commit 60f271a): https://prizm-v2--pr727-feat-input-number-hbtluscq.web.app (expires Mon, 23 Oct 2023 07:54:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ab7e21e23e82e687a92ac5a830ac2768df6e61b5 |
// } | ||
|
||
constructor( | ||
@Optional() @Self() public readonly ngControl: NgControl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Возможно, @optional стоит убрать
import { UntypedFormControl, Validators } from '@angular/forms'; | ||
import { tap } from 'rxjs/operators'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { tap } from 'rxjs/operators'; |
<br /> | ||
<div> | ||
Value: <b>{{ requiredInputControl.value }}</b> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<br /> | |
<div> | |
Value: <b>{{ requiredInputControl.value }}</b> | |
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...put-number/examples/input-number-invalid-example/input-number-invalid-example.component.html
Show resolved
Hide resolved
…number-invalid-example/input-number-invalid-example.component.html Co-authored-by: ickisIckis <darinafjordur@gmail.com>
Атрибут - decimal, при каких значение какое поведение подразумевалось. и что происходит с уже введенными значениями при изменении этого свойства ? |
Свойство presicion как должен работать? |
!!! check other inputs