Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components/input-number): convert directive to component #727

Merged
merged 23 commits into from
Oct 18, 2023

Conversation

ZurabDev
Copy link
Contributor

@ZurabDev ZurabDev commented Sep 14, 2023

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Visit the preview URL for this PR (updated for commit 60f271a):

https://prizm-v3--pr727-feat-input-number-wlh5nxjt.web.app

(expires Mon, 23 Oct 2023 07:53:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6cf3db9b3e1bf46180849c1db2e28221d0904ddf

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Visit the preview URL for this PR (updated for commit 60f271a):

https://prizm-v1--pr727-feat-input-number-1s3sqoyj.web.app

(expires Mon, 23 Oct 2023 07:55:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3f40bac4652dbd13be483e7e4de02de469ed4b3f

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Visit the preview URL for this PR (updated for commit 60f271a):

https://prizm-v2--pr727-feat-input-number-hbtluscq.web.app

(expires Mon, 23 Oct 2023 07:54:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ab7e21e23e82e687a92ac5a830ac2768df6e61b5

@ZurabDev ZurabDev added the state:ready ready for release (pass tested) label Sep 14, 2023
// }

constructor(
@Optional() @Self() public readonly ngControl: NgControl,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Возможно, @optional стоит убрать

import { UntypedFormControl, Validators } from '@angular/forms';
import { tap } from 'rxjs/operators';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { tap } from 'rxjs/operators';

Comment on lines 17 to 20
<br />
<div>
Value: <b>{{ requiredInputControl.value }}</b>
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<br />
<div>
Value: <b>{{ requiredInputControl.value }}</b>
</div>

Copy link

@Mainkira Mainkira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors в live demo

InputNumber эрроры в live demo

@ickisIckis ickisIckis added state:in_progress We work on this issue and removed state:ready ready for release (pass tested) labels Sep 18, 2023
@ickisIckis ickisIckis marked this pull request as draft September 18, 2023 07:49
@alexhawkins94
Copy link

Атрибут - decimal, при каких значение какое поведение подразумевалось. и что происходит с уже введенными значениями при изменении этого свойства ?

@alexhawkins94
Copy link

Свойство presicion как должен работать?
Input number counter float example - в этом примере precision = 2 а в дефолтном значении в примере уже 3 символа после точки. и что с округлениями в этом кейсе должно быть?

@ZurabDev ZurabDev merged commit 061a9c1 into main Oct 18, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment